-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] [GSoC 21] Media Manager - Responsive Images final version and "Insert/Edit Image" form improvements #35250
Draft
eyvazahmadzada
wants to merge
124
commits into
joomla:5.2-dev
Choose a base branch
from
eyvazahmadzada:responsive-images-final
base: 5.2-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
124 commits
Select commit
Hold shift + click to select a range
8a365b3
added: an image for testing
eyvazahmadzada 5ec2387
added: generateResponsiveImages function and tests
eyvazahmadzada fd0b19e
added: createResponsiveImages function and tests
eyvazahmadzada 5a6cbc1
added: test creation on save in article content
eyvazahmadzada db2be4f
added: intro and full article image generation on save
eyvazahmadzada e6d91bc
added: article content images generation
eyvazahmadzada f5ce3f2
deleted: duplicate code for generating images
eyvazahmadzada 72ea064
added: delete responsive images when not needed
eyvazahmadzada 06dc39f
added: full descs, removed: destFolder from createMultipleSizes
eyvazahmadzada f89c34c
Merge pull request #5 from joomla-projects/week1
sebenns 036fb37
Merge branch 'dev' of https://github.com/joomla-projects/gsoc21_media…
eyvazahmadzada 4801426
added: delete images when not used functionality
eyvazahmadzada b36c4e0
added: responsive images generation functionality to everywhere
eyvazahmadzada b7afb2b
added: image generation helper functions, removed: duplicate code fro…
eyvazahmadzada a4dbfc4
added: delete generated images when original gets deleted from media …
eyvazahmadzada 7054028
fixed: get content images pattern not specific for img issue
eyvazahmadzada ea61a1e
Update signature
bembelimen 92d674c
Merge pull request #10 from joomla-projects/4.1-dev
bembelimen 105afef
fixed: coding standard violations
eyvazahmadzada 2afcf09
Merge branch 'dev' of https://github.com/joomla-projects/gsoc21_media…
eyvazahmadzada 8415be8
added: function to insert srcset attribute to content img tags
eyvazahmadzada 49c385f
Merge branch 'dev' of github.com:joomla-projects/gsoc21_media-manager…
bembelimen c75ed29
Merge branch 'dev' of https://github.com/joomla-projects/gsoc21_media…
eyvazahmadzada bfa9724
fixed: unit test issues, removed: unnecessary comments and duplicate …
eyvazahmadzada e94294c
Merge branch 'week2' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 5b4b1f4
improved: add srcset function
eyvazahmadzada bbb5f78
fixed: image tests sizes type issue
eyvazahmadzada 312e13e
removed: test to check if height is correct without providing creatio…
eyvazahmadzada 8962061
removed: hardcoded image generation code from models
eyvazahmadzada 219c4a4
added: functions for getting form and content images
eyvazahmadzada 0454f9f
fixed: not being able to access old images issue
eyvazahmadzada 5b1294b
added: final plugin fixes
eyvazahmadzada 2524556
Merge branch 'week2' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 626e06c
added: insert srcset to content images functionality
eyvazahmadzada 415bb07
added: addSrcsetAndSizes function
eyvazahmadzada cfb7359
fixed: build system test error
eyvazahmadzada 5d32cc4
added: srcset generation fixes
eyvazahmadzada f78f71a
improved: image generation functions, added: srcset and sizes to form…
eyvazahmadzada 4c91e5b
fixed: small problem in createMultipleSizes
eyvazahmadzada 8607107
fixed: media item not showing after upload issue
eyvazahmadzada 23b43b3
fixed: Image method small issues
eyvazahmadzada 372349c
added: more fixes in plugin
eyvazahmadzada 9d1ea9a
added: phpcs fixes
eyvazahmadzada dfa5805
added: if check in onContentAfterSave
eyvazahmadzada c884c69
Merge branch 'week2' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 41d7dc7
Merge branch 'week3' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 173eef3
added: a separate plugin for handling responsive images
eyvazahmadzada 5a62995
added: plugin fixes
eyvazahmadzada a7a6de9
fixed: deleteMultipleSizes imagesize null
eyvazahmadzada 20da8b0
fixed: image test bugs
eyvazahmadzada 81fd191
fixed: testGenerateImageSizes assertion
eyvazahmadzada 52a61f4
fixed: testDeleteMultipleSizes issue
eyvazahmadzada 1ce2878
fixed: image methods creation method bugs
eyvazahmadzada d090600
nano fixes
eyvazahmadzada f9d7b89
added: nanofix
eyvazahmadzada 615c076
test build fix
eyvazahmadzada 3e777bb
fixed: phpcs small issue
eyvazahmadzada 026361d
Merge branch 'week3' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 4c4e4a1
added: delete responsive images in plugin
eyvazahmadzada 9983713
fixed: phpcs small error
eyvazahmadzada 3b51697
test build
eyvazahmadzada 21ef8b2
fixed: phpcs
eyvazahmadzada 96f53a6
added: plugin options customization
eyvazahmadzada d89303c
added: custom sizes for form images
eyvazahmadzada 69ad9e1
added: image customization forms
eyvazahmadzada 4a4d11f
added: update srcset and sizes functionality
eyvazahmadzada 6d766a5
added: $responsiveSizes scope modifier
eyvazahmadzada b4cbf66
fixed: ImageTest small issue
eyvazahmadzada 2272f7d
removed: deletion of responsive sizes when original is deleted
eyvazahmadzada 85ddd93
removed: unused code from plugin
eyvazahmadzada 5db6ff8
added: empty form size options handling
eyvazahmadzada 01cdfc4
fixed: plugin options for form images not working issue
eyvazahmadzada a6d4b45
fixed: phpcs
eyvazahmadzada 53b3123
fixed: small issues
eyvazahmadzada 126c525
fixed: banner view issue
eyvazahmadzada 2cc966b
added: jimage plugin initial version
eyvazahmadzada f17485c
added: insert/edit form controls
eyvazahmadzada 811460d
added: full image details editing functionality
eyvazahmadzada 5fbbbbf
added: responsive sizes form controls
eyvazahmadzada 802bf5e
added: content responsive images handling
eyvazahmadzada 5627c6e
fixed: typos and issues
eyvazahmadzada ba60a4c
removed: language prefixes from filenames
eyvazahmadzada 04e584d
Merge branch 'week5' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada ef60ea6
added: image title and creation method to plugin and form images
eyvazahmadzada 9b078d0
added: generate/createThumbs deprecation
eyvazahmadzada 97b0f48
Merge branch 'week5' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada aea13cd
Revert "Merge branch 'week5' of https://github.com/joomla-projects/gs…
eyvazahmadzada 2e0d230
added: title and custom creationMethod for all form images
eyvazahmadzada dc054db
added: content images creation method customization
eyvazahmadzada fbf4fcb
fixed: phpcs issues
eyvazahmadzada 29b034d
fixed: typos and issues
eyvazahmadzada 8b49081
removed: language prefixes from filenames
eyvazahmadzada cd3a4bf
added: generate/createThumbs deprecation
eyvazahmadzada 8befb9b
fixed: typos and issues
eyvazahmadzada 1466bd6
added: generate/createThumbs deprecation
eyvazahmadzada ecbc309
Merge branch 'week6' into week7
eyvazahmadzada 8de3f92
added: title field to content image edit form
eyvazahmadzada 8bee43b
Merge branch 'week7' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 91c476c
build test
eyvazahmadzada 4a5f846
added: mp4 and mp3 support, mediaelement config
eyvazahmadzada ea11656
fixed: ME.js error
eyvazahmadzada 5a17923
fixed: video and audio issues
eyvazahmadzada dc65b3f
added: translation strings
eyvazahmadzada 2579c37
added: translation strings and tags template fix
eyvazahmadzada 4a24523
added: updates
eyvazahmadzada 3f21fc6
Merge branch 'week6' into week7
eyvazahmadzada fccac8f
small update
eyvazahmadzada 006554a
Merge branch 'week7' of https://github.com/joomla-projects/gsoc21_med…
eyvazahmadzada 3e1fc72
changed: version numbers to __DEPLOY__
eyvazahmadzada b920b0e
fixed: js cs
eyvazahmadzada 56dc8b3
added: pdf preview, create/generateThumbs method tests
eyvazahmadzada 91d7462
improved: content image size customization
eyvazahmadzada be3d3da
added: responsive images fix and improvements
eyvazahmadzada d7f4223
added: unused responsive images detection
eyvazahmadzada 6aed088
added: separate ResponsiveImagesHelper function
eyvazahmadzada 3e017b4
added: unused images modal template, fixed: jimage plugin and templat…
eyvazahmadzada 03e35be
added: unused images alert
eyvazahmadzada ce87aa9
added: final responsive images fixes and improvements
eyvazahmadzada 466dc1b
phpcs one more fix
eyvazahmadzada 1f54101
Merge branch '4.1-dev' of https://github.com/eyvazahmadzada/joomla-cm…
eyvazahmadzada e9bb76a
added: final adjustments
eyvazahmadzada 0714c26
removed: unused code
eyvazahmadzada f1f211c
fixed: translation string duplications, added: title field to everywhere
eyvazahmadzada 8b68e32
added: more improvements and fixes
eyvazahmadzada File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added: unused images alert
- Loading branch information
commit 03e35beba391cbe5ee324cbe36bf41d178c1b94d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
<?php | ||
/** | ||
* @package Joomla.Plugin | ||
* @subpackage Content.responsiveimages | ||
* | ||
* @copyright (C) 2021 Open Source Matters, Inc. <https://www.joomla.org> | ||
* @license GNU General Public License version 2 or later; see LICENSE.txt | ||
*/ | ||
|
||
use Joomla\CMS\Factory; | ||
|
||
defined('_JEXEC') or die; | ||
|
||
?> | ||
|
||
<?php | ||
$document = Factory::getApplication()->getDocument(); | ||
|
||
// @TODO: Render a modal with images and checkboxes for checking and deleting them. | ||
$document->addScriptDeclaration(' | ||
document.addEventListener("DOMContentLoaded", function() { | ||
alert("Unused images: ' . implode(',', json_decode($images)) . '"); | ||
}); | ||
'); | ||
?> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as abuse.
Sorry, something went wrong.