-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3] backport of #35362 #35383
[3] backport of #35362 #35383
Conversation
@alikon Same as it was with the other PR at the beginning: Please change the comment in this line here
to I would have made a suggestion on GitHub but that doesn't work if the place of the suggestion in code is too far away from the code changed in a PR. |
I have tested this item ✅ successfully on 41bbe97 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35383. |
I have tested this item 🔴 unsuccessfully on 41bbe97 SELECT l.link_id, l.object,SUM(m.weight) AS ordering This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35383. |
@carcam I think you have mixed up the queries. There are 2 identical ones, one for getting the list items and another second one for getting the count. This PR here modifies that for the count. I.e. before ther PR there are 2 queries with ordering, and with this PR there is only one. You have to check that one which does not have the LIMIT clause. Please revert your wrong test result. Thanks in advance. |
@carcam It might be that you are right but the query which you have pasted in your test result is a query from Joomla 4. It cannot be used here in Joomla 3 in this way with prepared statement. |
I can confirm that this code does not seem to get triggered by smart search while i agree that we should clear the order thing in generally too. Will merge this based on the test by @bembelimen and @richard67 's and mine review. |
Summary of Changes
clear the order
Testing Instructions
see #35362