Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0]Update languages for TinyMCE #35599

Merged
merged 9 commits into from
Oct 17, 2021
Merged

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Sep 18, 2021

Pull Request for Issue #35579.

Summary of Changes

Updated languages done by TTs

Can be merged by maintainers by review.
But please wait for now, as I will add more languages as they come in.

@dgrammatiko
Copy link
Contributor

Updated languages done by TTs

Is there a repo for the files?

@Bakual
Copy link
Contributor Author

Bakual commented Sep 18, 2021

The TinyMCE project uses Transifex to do translations and our TTs can download the translation files from there (https://www.tiny.cloud/get-tiny/language-packages/).
However the files usually need some adjustments so they work with Joomla. Also language codes don't match. So we only include files proofread and adjusted by our translation teams.

@zero-24 zero-24 added this to the Joomla 4.0.4 milestone Sep 18, 2021
@infograf768
Copy link
Member

infograf768 commented Sep 18, 2021

https://www.tiny.cloud/get-tiny/language-packages/ downloadable files may be marked as fully translated but are not.
This is why we have a specific tool to create the files from a duplicate of any file there.
uconvert.php.zip

From TTs forum September 2 2013
Achal created for us a simple script. See above.

As you can see when editing one the tiny lang files, all utf8 characters are presented as /uabcd
Unreadable...

So, just pick up one of the files in https://www.tiny.cloud/get-tiny/language-packages/ 
change its name to fit, and edit in your favorite utf8 text editor.

Then load uconvert.php
http://localhost/uconvert.php

Copy/paste the content of your text file in the top text field.
Click "Convert"
Then copy the content of the bottom text field and create a new file for your language. Keep somewhere the readable version!

@zero-24
Copy link
Contributor

zero-24 commented Sep 21, 2021

As requested by @Bakual i have directly commited the update for de to this PR here as downloaded from tiny.cloud: Bakual@4be3582

@Bakual
Copy link
Contributor Author

Bakual commented Sep 21, 2021

Thanks, looks fine to me.

@bembelimen bembelimen marked this pull request as draft September 22, 2021 05:25
@bembelimen
Copy link
Contributor

bembelimen commented Sep 22, 2021

But please wait for now, as I will add more languages as they come in.

I moved it to draft state (so no accidentally merge), when ready, just convert it back to a regular PR to merge.

@Bakual
Copy link
Contributor Author

Bakual commented Sep 22, 2021

@bembelimen It just needs to be merged before the next release. It's always ready to be merged (by review). So "draft" is wrong.

@Bakual Bakual marked this pull request as ready for review September 22, 2021 13:52
Thomas Hunziker and others added 2 commits September 22, 2021 19:58
@wojsmol
Copy link
Contributor

wojsmol commented Sep 23, 2021

@Bakual Polish translation Bakual#18

@Bakual
Copy link
Contributor Author

Bakual commented Sep 23, 2021

Thanks @wojsmol , merged it into this PR

@wilsonge wilsonge merged commit 54c1f10 into joomla:4.0-dev Oct 17, 2021
@wilsonge
Copy link
Contributor

Thanks!

@Bakual Bakual deleted the 4_UpdateTinyLang branch October 17, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants