-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure a value is passed to base64_decode #36693
Merged
laoneo
merged 5 commits into
joomla:4.1-dev
from
roland-d:feature/cannot-give-null-to-base64
Jun 3, 2022
Merged
Make sure a value is passed to base64_decode #36693
laoneo
merged 5 commits into
joomla:4.1-dev
from
roland-d:feature/cannot-give-null-to-base64
Jun 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
I have tested this item ✅ successfully on 574fd8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36693. |
1 similar comment
I have tested this item ✅ successfully on 574fd8e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36693. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36693. |
Thanks! |
Denitz
pushed a commit
to Denitz/joomla-cms
that referenced
this pull request
Jun 4, 2022
* Make sure a value is passed to base64_decode Signed-off-by: Roland Dalmulder <contact@rolandd.com> * Also check if we have a redirect URL before checking it is internal Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Denitz
pushed a commit
to Denitz/joomla-cms
that referenced
this pull request
Jun 4, 2022
* Make sure a value is passed to base64_decode Signed-off-by: Roland Dalmulder <contact@rolandd.com> * Also check if we have a redirect URL before checking it is internal Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When installing a module on PHP 8.1 the following notice is observed in the Network Inspector:
base64_decode(): Passing null to parameter #1 ($string) of type string is deprecated
When the base64 issue is solved you get another notice:
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
This happens because there is no
return
value in the POST request. Not having thereturn
value is absolutely fine but we need to check if it has a value.This PR fixes that.
Testing Instructions
maximum
mod_test.zip
Actual result BEFORE applying this Pull Request
An error is shown due to 8.1 compatibility
Expected result AFTER applying this Pull Request
The 8.1 compatibility is solved.
Documentation Changes Required
None