[5.3] Add support for field groups when rendering custom fields in the frontend #36974
Conversation
Even though fields are grouped in the administrator console, the grouping of custom fields are not reflected in the frontend. The code here groups fields according to the field group they are a member of. If not, the output is left unchanged.
The group title could be a translatable language key. The update takes care of it.
|
Does this also solve #36967 ? |
|
@richard67 yes it does. |
|
@obuisard Could you fix the code style errors reported by Drone here? https://ci.joomla.org/joomla/joomla-cms/51568/1/6 Thanks in advance. |
Then please mention that at the top of your PR, too, and in future please try to avoid making duplicate issues if the existing issue can be found so easily. Thanks in advance. |
|
Shouldnt we at least try and be consistent and not have a mix of short and long array |
|
There is also #36265 for the grouping |
- adds the field name as class - adds suffix/prefix - adds the value render class - removes empty space when there is no render class
Fields are grouped in their respective field groups in their own fields-container
The default layout render.php breaks the html markup when rendered inside a subform (missing <dl>). This layout prevents such issue.
|
This pull requests has been automatically converted to the PSR-12 coding standard. |
|
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible. |
|
I know this is an old PR but it looked worth testing. I was rather expecting to have a custom field label look like a label - so a dt rather than a li. This is what it looks like: Contacts - I see no html errors with/without the patch. With the patch I see this: But the steps to get here are rather difficult to follow. I was expecting each item to be on a separate line but the source is this: So it works but could be better! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36974. |
|
This pull request has been automatically rebased to 5.1-dev. |
|
This pull request has been automatically rebased to 5.2-dev. |
HLeithner
changed the title
|
This pull request has been automatically rebased to 5.3-dev. |
HLeithner
changed the title
Pull Request for Issues #36967 and #36973.
Summary of Changes
This PR addresses:
Testing Instructions
In the admin console:
In the frontend:
Repeat with the Contacts component.
In addition, create a subform custom field for the Contacts component.
Include subform-only custom fields into the subform.
Test the output in the frontend for the subform. The default layout will break the HTML markup.
Go back to each subform-only custom field and set the layout to 'subform' (in the 'option' tab).
The subform should be properly displayed (no more broken dl/dd/dt markup).
Actual result BEFORE applying this Pull Request
Fields render as:
For com_contact, fields render as:
Expected result AFTER applying this Pull Request
Fields render as:
For com_contact, fields render as:
For com_contact, an additional layouts/field/subform.php is present to address issues found when contact custom fields are included inside a subform (it fixes the broken markup where dl tags are missing).
Documentation Changes Required
Yes, if there is any place where the frontend output of custom fields has been explained.
It will be necessary for the user to select the proper layout when including a contact custom field into a subform. This implies the custom field is only used in the subform.