-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1] Module "Articles - Categories" - Make the category selection optional #37116
Conversation
I have tested this item ✅ successfully on b8c2a08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116. |
I think the history on this code needs to be checked carefully. I'm sure there must be a reason. It is possibly related to multilingual |
Good point. It looks like it got added just to use the modal_category formfield for J3.7. Before that, the field was not required. |
I have tested this item ✅ successfully on b8c2a08 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37116. |
Does the category form field still work as expected? |
Why should it not work? I didn't change anything in the formfield. |
But you are changing back something which was introduced on purpose. If that still works, then all is fine. Just wanted to double check before merging. |
which is a big red warning flag to me |
I honestly doubt that it indeed was changed on purpose. Also, as I already wrote in the PR description, the code of the module already handles the case when no category is selected. I didn't had to change anything there. |
Thx |
The module "Articles - Categories" requires to select a parent category. But that means you can't have the module show all categories, you can only show a subset.
I think this is a requirement which is not needed. The code itself already falls back to "root" if no category is selected.
Summary of Changes
Removing the "required" flag from the parent category field.
Testing Instructions
Test the module "Articles - Categories" and make especially sure nothing breaks when no category is selected.
Actual result BEFORE applying this Pull Request
You always need to select a category and the module shows only subset of the article categories.
Expected result AFTER applying this Pull Request
You don't need to select a category and the module can show all categories.
Documentation Changes Required
None