Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Add support ID with 0 for value CheckboxField.php #37174

Open
wants to merge 22 commits into
base: 4.4-dev
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a00fab3
Update CheckboxField.php
korenevskiy Mar 2, 2022
f046dfc
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Mar 2, 2022
077307b
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Mar 11, 2022
bf69288
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Mar 22, 2022
7f9fe10
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy May 15, 2022
0f740cf
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy May 15, 2022
90e9c8f
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy May 16, 2022
00ca955
Merge branch '4.1-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy May 18, 2022
41ee029
Merge tag 'psr12anchor' into psr12/merge/37174
joomla-bot Jun 27, 2022
6b50a50
Phase 1 convert BRANCH to PSR-12
joomla-bot Jun 27, 2022
e78c560
Phase 2 convert BRANCH to PSR-12
joomla-bot Jun 27, 2022
d318b9e
Merge tag 'psr12final' into psr12/merge/37174
joomla-bot Jun 27, 2022
ad187b5
Merge branch '4.2-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Jul 1, 2022
2dd5106
Merge branch '4.2-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Aug 27, 2022
44e1f9b
Merge branch '4.2-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Sep 6, 2022
9902b63
Update libraries/src/Form/Field/CheckboxField.php
korenevskiy Oct 24, 2022
7f1cc63
Merge branch '4.2-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Oct 24, 2022
116ed66
Update CheckboxField.php
korenevskiy Jul 13, 2023
6fd6fcb
Merge branch '4.3-dev' into Add-support-ID-with-0-for-value-CheckboxF…
korenevskiy Jul 13, 2023
62dbe91
Update CheckboxField.php
korenevskiy Jul 13, 2023
57af46d
Update CheckboxField.php
korenevskiy Jul 13, 2023
8b05ef3
Update CheckboxField.php
korenevskiy Jul 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libraries/src/Form/Field/CheckboxField.php
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,8 @@ public function setup(\SimpleXMLElement $element, $value, $group = null)
protected function getLayoutData()
{
$data = parent::getLayoutData();
$data['value'] = $this->default ?: '1';
// The explicitly set default value is '0' for using index definitions in arrays and tables of form fields
$data['value'] = $this->default !== null && $this->default !== '' ? $this->default : '1';
korenevskiy marked this conversation as resolved.
Show resolved Hide resolved
$data['checked'] = $this->checked || $this->value;

return $data;
Expand Down