Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Using languagecode system parameters to display lang tag in assoc badges #37289

Open
wants to merge 13 commits into
base: 5.3-dev
Choose a base branch
from
Open

[5.3] Using languagecode system parameters to display lang tag in assoc badges #37289

wants to merge 13 commits into from

Conversation

infograf768
Copy link
Member

@infograf768 infograf768 commented Mar 16, 2022 •
edited
Loading

Solving #37228 (comment)

Summary of Changes

Checking in each case if the language code plugin is enabled and if so, modify the associations badges to use the lang tag defined by the plugin.

Testing Instructions

Create a multilingual site.
Enable the languagecode system plugin and give a new lang tag value for a language.

Example:
Screenshot 2022-03-16 at 11 29 48

Expected result AFTER applying this Pull Request

Every occurrence of a badge displaying the installed language tag will display the new tag.

Screenshot 2022-03-16 at 11 31 48

Screenshot 2022-03-16 at 11 33 07

Screenshot 2022-03-16 at 11 34 47

  • com_associations, com_contact, com_categories, com_menus, com_newsfeeds

@infograf768 infograf768 mentioned this pull request Mar 16, 2022
Closed
@infograf768 infograf768 changed the title [4.1] Using languagecode system parameters to display lang tag in [4.1] Using languagecode system parameters to display lang tag in assoc badges Mar 16, 2022
@richard67
Copy link
Member

Maybe it should be rebased to 4.2-dev because it’s some kind of new feature? If so, I will help if necessary e.g. if JM has little time.

@infograf768
Copy link
Member Author

@richard67
Please do whatever is better.

@HLeithner HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:05
@HLeithner
Copy link
Member

This pull request has automatically rebased to 4.2-dev.

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@rdeutz rdeutz removed the PR-4.1-dev label Aug 1, 2022
@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev.

@ceford
Copy link
Contributor

ceford commented Sep 14, 2023

Not sure about this. With the patch applied I see the language tag I entered in the Articles list. But I don't see any language tags in the Menus Dashboard or in the admin Main Menu. The html tags contains the tag I entered <html lang="de-ch" dir="ltr">. Is this is a valid test.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37289.

@brianteeman
Copy link
Contributor

@ceford this is a pr with merge conflicts that prevent testing

image

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:52
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:09
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [4.1] Using languagecode system parameters to display lang tag in assoc badges [5.2] Using languagecode system parameters to display lang tag in assoc badges Apr 24, 2024
@fgsw
Copy link

fgsw commented Sep 2, 2024

@infograf768 can you resolve the conflicts so the pull request can get a test?

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:53
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2] Using languagecode system parameters to display lang tag in assoc badges [5.3] Using languagecode system parameters to display lang tag in assoc badges Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrammatiko dgrammatiko dgrammatiko left review comments

@richard67 richard67 richard67 left review comments

Assignees
No one assigned
Labels
Conflicting Files Feature PR-5.3-dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.