Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Filter articles in admin module mod_latest by workflow stage #37366

Open
wants to merge 14 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

magnussinger
Copy link
Contributor

Pull Request for Issue #36802

Summary of Changes

In the backends latest articles module, one can now filter by active stages from the workflows of the respective articles

Testing Instructions

Create multiple articles with different stages of workflows, then edit the module to filter certain stages

Actual result BEFORE applying this Pull Request

You were not able to filter by stages

Expected result AFTER applying this Pull Request

You are now able to filter by workflow stage

Documentation Changes Required

None

@teekhandekar
Copy link

@magnussinger hey! here it says that this branch is out-of-date with the base branch
so is the issue still open and if yes can I work on this ?

@magnussinger
Copy link
Contributor Author

Hi @teekhandekar, you can always work on any issue if you want, and you don't need to ask for it. But in this case, I just had to merge the base branch into my branch, so it wasn't much to do.

@laoneo
Copy link
Member

laoneo commented Mar 28, 2022

@magnussinger can you rebase the pr to the 4.2-dev branch as it is a new feature?

@magnussinger
Copy link
Contributor Author

Sure

@magnussinger magnussinger changed the base branch from 4.1-dev to 4.2-dev March 28, 2022 13:49
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@brianteeman
Copy link
Contributor

Sorry but this is not correct.

  1. Instead of the sql field why not use the existing workflowstage field type. This has numerous advantages especially when there is more that one workflow on the site
  2. You are not checking to see if the site is using workflows before display the stage field

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jun 6, 2022
@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the Feature label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 5.0-dev May 2, 2023 16:42
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.0-dev.

@web54
Copy link

web54 commented Aug 26, 2023

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@TLWebdesign
Copy link

I have tested this item ✅ successfully on b260e85

Tested on ‎5.0.0-beta1-dev PBF


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@ceford
Copy link
Contributor

ceford commented Sep 15, 2023

With the patch applied I see a string key as may only choice: <option value="1">COM_WORKFLOW_BASIC_STAGE</option> in the Stage filter field.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37366.

@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev September 30, 2023 22:51
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.1-dev.

@hannazn
Copy link

hannazn commented Feb 24, 2024

Tested the issue successfully ✅

@dennise24
Copy link

I have tested this item ✅ successfully

@stimpsonjcat
Copy link

Tested this on Joomla 5.1 alpha 4
There is no option to select no workflow. The first workflow stage in the list automatically selected.
There's a translation issue with com_workflow_basic_stage.
workflow stages in module

@HLeithner HLeithner changed the base branch from 5.1-dev to 5.2-dev April 24, 2024 09:09
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.2-dev.

@HLeithner HLeithner changed the title [4.x] Filter articles in admin module mod_latest by workflow stage [5.2] Filter articles in admin module mod_latest by workflow stage Apr 24, 2024
@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:53
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2] Filter articles in admin module mod_latest by workflow stage [5.3] Filter articles in admin module mod_latest by workflow stage Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PBF Pizza, Bugs and Fun PR-5.3-dev Small A PR which only has a small change Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.