-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.4] Fix media downloads with spaces #37396
base: 4.4-dev
Are you sure you want to change the base?
Conversation
Please edit this pull request so that the title is descriptive. It is used as the commit message and changelog Then please update the first post so that it answers the questions you were asked when opening the pull request |
Why did you close this? |
@Vanshitasingh you can add changes to your PR - make new commits, no need to make a new one . |
Got it! |
This is still closed? |
@Vanshitasingh please update/edit the PR title to something more descriptive like "Fix Media Downloads with Spaces" (example). You can make this change without closing the PR. |
@ditsuke yes, done. |
This pull request has automatically rebased to 4.2-dev. |
This pull requests has been automatically converted to the PSR-12 coding standard. |
This pull request has been automatically rebased to 4.3-dev. |
This pull request has been automatically rebased to 4.4-dev. |
I have tested this item 🔴 unsuccessfully on 091082a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396. |
Can you please fix this so that we can test this during PBF on saturday? |
I have tested this item ✅ successfully on 091082a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396. |
Pull Request for Issue #37369.
Summary Of Changes
Fixed Media Downloads with Spaces
Testing Instructions
Replaced '%20' with space gaps using replace function.
Actual result BEFORE applying this Pull Request
The file with spaces in it loses everything between the first and second space.
Expected result AFTER applying this Pull Request
spaces are kept intact.