Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix media downloads with spaces #37396

Open
wants to merge 8 commits into
base: 4.4-dev
Choose a base branch
from

Conversation

Vanshitasingh
Copy link

@Vanshitasingh Vanshitasingh commented Mar 28, 2022

Pull Request for Issue #37369.

Summary Of Changes
Fixed Media Downloads with Spaces

Testing Instructions
Replaced '%20' with space gaps using replace function.

Actual result BEFORE applying this Pull Request
The file with spaces in it loses everything between the first and second space.

Expected result AFTER applying this Pull Request
spaces are kept intact.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Mar 28, 2022
@brianteeman
Copy link
Contributor

Please edit this pull request so that the title is descriptive. It is used as the commit message and changelog

Then please update the first post so that it answers the questions you were asked when opening the pull request
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request

@brianteeman
Copy link
Contributor

Why did you close this?

@chmst
Copy link
Contributor

chmst commented Mar 28, 2022

@Vanshitasingh you can add changes to your PR - make new commits, no need to make a new one .

@Vanshitasingh
Copy link
Author

Got it!

@brianteeman
Copy link
Contributor

This is still closed?

@Vanshitasingh Vanshitasingh reopened this Apr 6, 2022
@ditsuke
Copy link
Contributor

ditsuke commented Apr 10, 2022

@Vanshitasingh please update/edit the PR title to something more descriptive like "Fix Media Downloads with Spaces" (example). You can make this change without closing the PR.

@Vanshitasingh
Copy link
Author

@ditsuke yes, done.

@Quy Quy changed the title Fixed Issue #37369 [4.1] Fix media downloads with spaces Apr 19, 2022
@richard67 richard67 added the PBF Pizza, Bugs and Fun label Apr 22, 2022
@HLeithner HLeithner changed the base branch from 4.1-dev to 4.2-dev June 27, 2022 13:05
@HLeithner
Copy link
Member

This pull request has automatically rebased to 4.2-dev.

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@HLeithner HLeithner removed the psr12 label Oct 23, 2022
@Hackwar Hackwar added the Small A PR which only has a small change label Feb 26, 2023
@Hackwar Hackwar added the bug label Apr 6, 2023
@HLeithner HLeithner changed the base branch from 4.2-dev to 4.3-dev May 2, 2023 16:30
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.3-dev.

@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:45
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@Quy
Copy link
Contributor

Quy commented Feb 7, 2024

I have tested this item 🔴 unsuccessfully on 091082a

Displays Download m due to name[1] which is the second character in images/.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396.

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Feb 7, 2024
@Hackwar
Copy link
Member

Hackwar commented Feb 21, 2024

Can you please fix this so that we can test this during PBF on saturday?

@sergejsteinz
Copy link

I have tested this item ✅ successfully on 091082a

I have tested this item ✅ successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37396.

@HLeithner HLeithner changed the title [4.1] Fix media downloads with spaces [4.4] Fix media downloads with spaces Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PBF Pizza, Bugs and Fun PR-4.4-dev Small A PR which only has a small change Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet