[4.x] Workflow Featured #37561
[4.x] Workflow Featured #37561
Conversation
This pr checks if workflows is enable and if it is changes the "featured status" to not display the Toggle message which is incorrect as it is disabled
|
I have tested this item ✅ successfully on b5d2fa7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561. |
|
Works as it should. I note that the problem is solved for favorites, but a similar problem for the state of the publication. With the workflow enabled, there is still a line telling you to click to toggle, but there is no clickability in the workflow for these icons.
|
|
please create a neew issue for that |
|
I have tested this item ✅ successfully on b5d2fa7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561. |
| $this->addState(1, 'unfeatured', 'icon-color-featured icon-star', | ||
| Text::_('JGLOBAL_TOGGLE_FEATURED'), ['tip_title' => Text::_('JFEATURED')] | ||
| ); | ||
| $workflow_featured = Factory::getApplication()->bootComponent('com_content')->isFunctionalityUsed('core.featured', 'com_content.article'); |
There was a problem hiding this comment.
Is this button only used on com_content? If not, then we shouldn't add here a hard dependency to it.
There was a problem hiding this comment.
workflow only works on com-content
There was a problem hiding this comment.
Then you need to move the button to com_content. The libraries classes shouldn't have a hard dependency to a specific extension.
There was a problem hiding this comment.
good luck with that
There was a problem hiding this comment.
Ok, had a look how the button is used. As an instance is directly created in the com_content component you can pass the component reference in the constructor of the button and use that one. If it is not set, do the fallback to com_content.
There was a problem hiding this comment.
workflow only works on com-content
Currently yes, but this is to be changed sooner or later so it works for other components, too.
laoneo
added
the
Updates Requested
laoneo
removed
RTC
|
Back to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37561. |
|
@brianteeman do you have any intention to pass the component to the button? |
|
no |
|
Ok, then I'm closing this one because of the reasons stated above and will reopen the issue. Thanks for your understanding. |
|
in another year perhaps someone will look at it again |
This pr checks if workflows is enable and if it is changes the "featured status" to not display the Toggle message which is incorrect as it is disabled
Pull Request for Issue #34502 .
Expected result AFTER applying this Pull Request
Documentation Changes Required