Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Implement 'requireon' attribute to form fields for conditional requiredness #37798

Open
wants to merge 29 commits into
base: 5.2-dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
b18a54f
Add requireon assets
stephan-ansems May 15, 2022
5cc6064
New requireon.es6.js asset
stephan-ansems May 15, 2022
b6dee15
Render requireon conditions for options
stephan-ansems May 15, 2022
0cb5e9c
Ensure requireon js asset is loaded when needed
stephan-ansems May 15, 2022
0cfa1f2
Add requireon functionality to filters
stephan-ansems May 15, 2022
773f199
Add requireon feature
stephan-ansems May 15, 2022
5bc9fff
Implement requireon feature
stephan-ansems May 15, 2022
d7090ee
Renamed parseShowOnConditions to parseFieldConditions
stephan-ansems May 15, 2022
4dfdfae
Removed one last remnant of shopon
stephan-ansems May 15, 2022
73a4992
add requireon feature
stephan-ansems May 15, 2022
5462004
Update options_default.php
stephan-ansems May 15, 2022
72bb439
refactoring of FormHelper
stephan-ansems May 15, 2022
8d2d4e6
Refactoring of FormHelper
stephan-ansems May 15, 2022
89ecdde
Refactoring of FormHelper
stephan-ansems May 15, 2022
2ec4c1e
Fixed $$ typo
stephan-ansems May 15, 2022
e08f554
Added old function back for b/w compatibility
stephan-ansems May 15, 2022
151786b
Whitespaces...
stephan-ansems May 15, 2022
a0bc495
Update FormHelper.php
stephan-ansems May 15, 2022
b121c96
Code style correction
stephan-ansems May 16, 2022
7809df3
requireon no longer overwrites showon conditions
stephan-ansems May 16, 2022
fb22a6e
requireon no longer overwrites showon conditions
stephan-ansems May 16, 2022
399a903
Changed a comment
stephan-ansems May 16, 2022
b60565c
Whitespace again!!
stephan-ansems May 16, 2022
c547e11
Merge branch 'joomla:4.2-dev' into 4.2-dev
stephan-ansems May 17, 2022
ff79b74
Merge branch '4.2-dev' into 4.2-dev
stephan-ansems May 18, 2022
3a97534
Merge tag 'psr12anchor' into psr12/merge/37798
joomla-bot Jun 27, 2022
871b8ae
Phase 1 convert BRANCH to PSR-12
joomla-bot Jun 27, 2022
bf26a6a
Phase 2 convert BRANCH to PSR-12
joomla-bot Jun 27, 2022
25e0858
Merge tag 'psr12final' into psr12/merge/37798
joomla-bot Jun 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code style correction
Thanks to @richard67

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
  • Loading branch information
stephan-ansems and richard67 committed May 16, 2022
commit b121c9611d79504264714e65dd449328687e94f4
2 changes: 1 addition & 1 deletion libraries/src/Form/FormField.php
Original file line number Diff line number Diff line change
Expand Up @@ -1397,7 +1397,7 @@ protected function getLayoutData()
'validationtext' => $this->validationtext,
'readonly' => $this->readonly,
'repeat' => $this->repeat,
'required' => (bool) $this->required ||(bool) $this->requireon,
'required' => (bool) $this->required || (bool) $this->requireon,
'size' => $this->size,
'spellcheck' => $this->spellcheck,
'validate' => $this->validate,
Expand Down