-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Workflow emails #37860
base: 5.2-dev
Are you sure you want to change the base?
[5.2] Workflow emails #37860
Conversation
…s to a users email address Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Great addition. The "Additional Message Text" field must be removed. First, we find ourselves in a similar situation, which I described in the issue #37493. Secondly, if we add text in this field and we select both methods of receiving a notification, then we will receive this additional text in personal messages, but we will NOT receive it in email, since this additional text will not be in the letter template. Thirdly, in this field we do not see the real message (only the description), but we see it in the email template. In short, we really need to leave 1 place for setting the "body" of the notification and this place in the email templates. We can mention this in the description for the "Notification Type" parameter. |
Doesn't make any sense to keep the old broken behaviour as an option You're introducing a new method that fixes the bugs in the old method but still leave the old method there with its bugs |
You cannot have a required field that is conditionaly displayed. You have made the notification type a required field but is only shown when send email is set to yes. |
I really dont undrstand why you have kept the broken private messages version. There is no explanation or why you would use method email or method private messags and you can still select groups and users to receive private messages which will neveer be sent. |
It needs to be clearer that you can customise the mail further if you are using the email method by using th email templates BUT that it is a generic template for all transition notification emails and you must put anything specific to the transition in the notification config only. |
In what scenario would anyone ever send a message by email AND private message? |
Co-authored-by: Brian Teeman <brian@teeman.net>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
This cannot be removed as it will be a backwards compatible break.
You can add the additional text to the email. This is a valid point that the extra text should be in the default mail template. I have updated this PR with that change.
I do not understand this. Can you explain this further?
That is something I was thinking about but really have no idea how we should do this. First I cannot remove this addition message text due to backwards compatibility break. Second, we could create a mail template for every transition but these cannot be in core because we have no idea which transitions there will be.
I cannot remove sending messages to private messages because that would be a backwards compatible break. I would not say it is broken but rather limited as we can only send messages to users with access to private messages.
Actually you can. The required condition is only active when the field is displayed.
Any suggestions for a text to add?
I saw your other issue about that but this is not in scope of this PR. I can look at that in a separate PR.
See my remark above for Kostelano, he basically says the same thing. Any suggestions on how to improve this are welcome.
I knew this was coming :) If I chose a single dropdown the request would come to make it multiple, make it multiple and the request will come for a single dropdown. Ghehehehe. So my reasoning is that the transition message can be send but may not arrive in the mail but you can see it in your private message box. Why limit the options for the user? We can let the user decide what they want to use, we do not have to decide for them. |
No its not B/C break you are just changing from a completely broken method to a working method
I do not write things just for the sake of writing words. I tested the PR. (and I know that we already have the same bug elsewhere.)
Of course it is in the scope of this PR. Otherwise it doesn't fix the bug you state this pr fixes. |
@Kostelano you need the "additional text" field. Without it you cannot have a unique message for each notification. Mail templates are for general customisations of all notification emails |
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
It works on the site where we are using workflow. Messages go to the private message box.
I also tested this of course but did not read between your lines that there should not be an option selected. I removed the requirement. |
I have tested this item 🔴 unsuccessfully on a94c821 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37860. |
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Konstantin Kolos <k0nstantinkolos88@gmail.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Rebased to 4.3 |
Hi, i'v upgraded a CLEAN installation of joomla 4.2.0 to the last one 4.2.2. ALTER TABLE This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37860. |
@roland-d As the PR has been rebased to 4.3-dev, the update SQL scripts "4.2.0-2022-05-22.sql" need to be renamed to something later than the up to now latest 4.3 update SQL scripts "4.3.0-2022-09-23.sql". I would suggest "4.3.0-2022-10-23.sql". |
@obuisard Please don't merge this before the update SQL scripts have been renamed, see my previous comment. |
No worries Richard, I was not going to merge it as I saw your comments :-) |
I have tested this item 🔴 unsuccessfully on cd97f4b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37860. |
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible. |
@micker If there is no other super user besides the one who causes the notification, then there is nobody to send email to. Create another user user and that other one should get the email if the first super user changes something and your email sending is set up right. |
I have tested this item ✅ successfully on cd97f4b maybe 2 return 😄
|
This pull request has been automatically rebased to 5.1-dev. |
This pull request has been automatically rebased to 5.2-dev. |
Pull Request for Issue #37745 #37446 .
Summary of Changes
This change adds the option to select email as a notification type. Users can send notifications to:
Testing Instructions
First you need to apply this PR. Since there are database changes you will need to run those as well.
For MySQL users run this on your database:
For Postgres users run this on your database:
Private Messages
is the old and default way of sending notifications. Clicking on the dropdown now also let's you selectEmail
as an option. Multiple options are possible as wellUnpublished
Mail templates
The sending of the emails uses the mail templates in Joomla. The mail template can be customized via these steps:
workflow
Feedback requested
The following questions I have:
performer
Any suggestions for a better name?@brianteeman Could you please check the language files?
Final words
Thanks to @bembelimen and @softforge for the idea to add this. Thanks to @brianteeman to point out to use mail templates.
I know this isn't perfect code so looking for feedback to get this into Joomla to make transitions more useful as they are quite neat.
Actual result BEFORE applying this Pull Request
Messages are only sent to users who can receive private messages
Expected result AFTER applying this Pull Request
Messages can now also be send to users with an account and email address.
Documentation Changes Required
Yes, need to document the addition of the email option.