Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored WebAuthn with Windows Hello support #37910

Merged
merged 57 commits into from
Jun 27, 2022
Merged

Refactored WebAuthn with Windows Hello support #37910

Changes from 1 commit
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
0a3d81c
Refactored WebAuthn plugin
nikosdion Apr 26, 2022
b8a6ad7
Fix the WebAuthn management page which was broken in https://github.c…
nikosdion Apr 26, 2022
c8c6446
Fix wrong `@since` doc tag
nikosdion Apr 27, 2022
abb868c
Fix docblock typo
nikosdion Apr 27, 2022
8246463
Fix docblock typo
nikosdion Apr 27, 2022
444a8db
Fix docblock typo
nikosdion Apr 27, 2022
6396ba8
Fix docblock typo
nikosdion Apr 27, 2022
ec5e32a
Fix docblock typo
nikosdion Apr 27, 2022
9c261d1
Fix broken management interface
nikosdion Apr 27, 2022
7966047
Make unnecessarily static method back into non-static
nikosdion Apr 27, 2022
833fe6e
Replace static helper with injected object
nikosdion Apr 27, 2022
7381a4b
Come on, commit the ENTIRE file!
nikosdion Apr 27, 2022
0bc36d6
Use the user factory
nikosdion Apr 27, 2022
b80b3b9
Fix error when going through the user factory
Apr 27, 2022
cb89159
Fix: cannot add WebAuthn authenticator right back after deleting it
nikosdion Apr 27, 2022
78d7fd5
Remove useless switch branch
nikosdion Apr 27, 2022
2dc8c4a
Remove useless exception
nikosdion Apr 27, 2022
1b3d4ee
Display make and model of the authenticator, if possible
nikosdion Apr 28, 2022
f019fde
Add missing JWT signature algorithms
nikosdion Apr 28, 2022
786d165
Fix copyright date
nikosdion Apr 28, 2022
d3671b9
Fix for PHP 8 using FIDO keys and Android phones
nikosdion Apr 28, 2022
ca5451a
Reactivate the tooltips after adding an authenticator
nikosdion Apr 28, 2022
09140d0
Option to disable the attestation support
nikosdion Apr 28, 2022
71815ff
The Windows Hello icon was invisible on white background
nikosdion Apr 28, 2022
d2e20ce
Attempt to fix Appveyor not having Sodium in the Windows build
nikosdion Apr 29, 2022
0c32939
Work around third party library bug...
nikosdion Apr 29, 2022
ae9234b
Merge branch '4.2-dev' into feature/webauthn-refactor-2
richard67 May 4, 2022
dace695
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion May 24, 2022
6de7bdb
Create events in a forwards-compatible manner
nikosdion May 24, 2022
c03b191
Concrete events
nikosdion May 24, 2022
100605b
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion May 27, 2022
9f8d55e
Merge branch '4.2-dev' into feature/webauthn-refactor-2
richard67 Jun 6, 2022
784f878
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion Jun 12, 2022
9af4218
Fix event woes
nikosdion Jun 12, 2022
1d26630
Update plugins/system/webauthn/webauthn.xml
nikosdion Jun 13, 2022
0b973ea
Update administrator/language/en-GB/plg_system_webauthn.ini
nikosdion Jun 13, 2022
66249ac
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion Jun 13, 2022
3cab3a8
Merge branch '4.2-dev' into feature/webauthn-refactor-2
roland-d Jun 15, 2022
07c2c05
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion Jun 17, 2022
50f2f4e
Improve the layout for editing an authenticator
nikosdion Jun 17, 2022
843ccbd
Confirm deletion of authenticators
nikosdion Jun 17, 2022
d0a3b5f
Make the bots happy again
nikosdion Jun 17, 2022
4477f10
Merge branch '4.2-dev' into feature/webauthn-refactor-2
laoneo Jun 19, 2022
fbfba3c
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion Jun 20, 2022
c848533
Code polishing
nikosdion Jun 20, 2022
95316ff
Merge remote-tracking branch 'nikosdion/feature/webauthn-refactor-2' …
nikosdion Jun 20, 2022
218ec93
Merge branch '4.2-dev' into feature/webauthn-refactor-2
roland-d Jun 22, 2022
a7cdd3f
Blind fix
nikosdion Jun 23, 2022
c451923
Bring application injection in sync with core
HLeithner Jun 24, 2022
bcdcbaa
Merge pull request #9 from HLeithner/hello-windows
nikosdion Jun 24, 2022
61296c8
Remove whitespace
wilsonge Jun 24, 2022
2ae690b
Add use statement
wilsonge Jun 24, 2022
7f97cc2
Merge branch '4.2-dev' into feature/webauthn-refactor-2
richard67 Jun 26, 2022
7ef74c5
Fix wrong event creation in AjaxHandlerLogin
nikosdion Jun 27, 2022
c8503a9
Merge branch '4.2-dev' into feature/webauthn-refactor-2
nikosdion Jun 27, 2022
fc94359
License change
nikosdion Jun 27, 2022
6f1a658
Merge branch '4.2-dev' into feature/webauthn-refactor-2
HLeithner Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
The Windows Hello icon was invisible on white background
  • Loading branch information
Nicholas K. Dionysopoulos committed Apr 28, 2022
commit 71815ff82acca78f380602f3afa8ede266dfa786
2 changes: 1 addition & 1 deletion layouts/plugins/system/webauthn/manage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
$authMetadata = $knownAuthenticators[$aaguid->toString()] ?? $knownAuthenticators[''];
?>
<td class="text-center">
<img class="plg_system_webauth-has-tooltip img-thumbnail p-1"
<img class="plg_system_webauth-has-tooltip bg-secondary"
style="max-width: 6em; max-height: 3em"
src="<?php echo $authMetadata->icon ?>"
alt="<?php echo $authMetadata->description ?>"
Expand Down