Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inlinehelp] Add inlinehelp toggle button for each component config [PART 2] #38014

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented Jun 8, 2022

PART 2 of the PR #38005

Pull Request adding support for inlinehelp toggle button in core component having options but none with a description.
It makes it ready to display the toggle button if any description added later.

This PR requires PR #37915 in order to hide the "Toggle Inline Help" button if no form field with a description.

Summary of Changes

Added to the following components:

  • Menus > com_menus
  • Tags > com_tags
  • Templates > com_templates
  • User Actions Log > com_actionlogs

Testing Instructions

Actual result BEFORE applying this Pull Request

  • No inlinehelp toggle button and no description.

Expected result AFTER applying this Pull Request

  • Nothing changed (just ready for future descriptions that could be added to the form fields)

@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 7dcb92e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

@conseilgouz
Copy link
Contributor

I have tested this item ✅ successfully on 7dcb92e

Needs PR #37915 which needs one more human test to be RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

@chmst
Copy link
Contributor

chmst commented Jun 9, 2022

RTC - Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

@chmst chmst removed the PR-4.1-dev label Jun 9, 2022
@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 9, 2022
@Quy Quy added the PR-4.1-dev label Jun 9, 2022
@bembelimen bembelimen merged commit c3650ca into joomla:4.1-dev Jun 10, 2022
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 10, 2022
@bembelimen bembelimen added this to the Joomla 4.1.5 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants