[5.2] Fix for missing Fulltext Image in Newsfeeds

[AndySDH]

As requested, Joomla 4.2 re-do of Pull Request #28195

Summary of Changes

Originally Joomla RSS Newsfeeds were completely missing the image_intro and image_fulltext. This was partially fixed with this PR: #11402

But that only introduced the image_intro, and forgot the image_fulltext.

So an article that had an image_fulltext would not use that image in the feed.

This PR simply adds the image_fulltext to the feed if the image_intro is empty, for both the category view and featured view.

[richard67]

@AndySDH Could you fix the code style errors reported by drone here https://ci.joomla.org/joomla/joomla-cms/55308/1/6 ? Thanks in advance.

[AndySDH]

@richard67 Should be done :)

[richard67]

@richard67 Should be done :)

@AndySDH Not really. There are still some complaints: https://ci.joomla.org/joomla/joomla-cms/55316/1/6

[richard67]

@AndySDH Still not ok: https://ci.joomla.org/joomla/joomla-cms/55320/1/6 .

[AndySDH]

Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.

[richard67]

Well it's going in circles a bit. If I take out those spaces, the indentation will look off. I'm not sure that's a valid complaint there, not sure.

@AndySDH It is a valid complaint. The indentation of the “=“ and the lines below do not need to be aligned. Furthermore the lines below should be indented with tabs. I would also suggest to put the operators “?” and “:” of the ternaries to the beginning of a line and not the end of the previous line. And I would indent the 2nd ternary by one tab more than the first one. Maybe check how it is done elsewhere.

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[AndySDH]

Hello, this needs some tests please!

[stimpsonjcat]

Confirmed this works. ✅
I created an article with only a full text image. Left the intro image blank. The feed now will show the full text image in the feed.

[stimpsonjcat]

I have tested this item ✅ successfully on b2d557e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38058.}

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[AndySDH]

Hey there, can this please be merged?

[brianteeman]

You need to fic the codestyle issues https://ci.joomla.org/joomla/joomla-cms/76705/1/7

[AndySDH]

How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore

[brianteeman]

How do I fix? Didn't it use to be automatic with the click of a button? Can't see it anymore

No you have to fix it in your branch and push the changes

[AndySDH]

And what is the fix I need to make? I can't tell from the phpcs log, it's not very clear.

[AndySDH]

Thank you, committed :)