Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Move demo tasks to service provider #38098

Merged
merged 5 commits into from
Jun 27, 2022

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jun 19, 2022

Summary of Changes

Move the demo task plugin to service provider.

Testing Instructions

Create different demo tasks like the memory stress test or sleep.

Actual result BEFORE applying this Pull Request

All works.

Expected result AFTER applying this Pull Request

All works.

@alikon
Copy link
Contributor

alikon commented Jun 21, 2022

I have tested this item ✅ successfully on ee60281


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38098.

1 similar comment
@heelc29
Copy link
Contributor

heelc29 commented Jun 21, 2022

I have tested this item ✅ successfully on ee60281


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38098.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38098.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 21, 2022
@richard67
Copy link
Member

richard67 commented Jun 21, 2022

If this gets merged before 4.0.0-beta2, I will have to update the list of deleted files in script.php again. I would need to add file "/plugins/task/demotasks/demotasks.php" to the list of deleted files at line 6485.

I've prepared already a branch for that.

richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 21, 2022
@alikon
Copy link
Contributor

alikon commented Jun 21, 2022

wait then ...
consider this too #38072

@richard67
Copy link
Member

wait then ... consider this too #38072

@alikon Sure, when it has RTC I will add the "plugins/task/checkfiles/checkfiles.php" file, too.

@roland-d roland-d merged commit 10188de into joomla:4.2-dev Jun 27, 2022
@roland-d roland-d deleted the j4/plugins/demotasks branch June 27, 2022 12:28
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 27, 2022
@roland-d
Copy link
Contributor

Thanks everybody

@roland-d roland-d added this to the Joomla 4.2.0 milestone Jun 27, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 27, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 28, 2022
roland-d pushed a commit that referenced this pull request Jul 3, 2022
* Add deleted file from PR #38098

* Phase 1 convert BRANCH to PSR-12

* Add deleted files and folders from PR #37910

* Add deleted file from PR #38072
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2022
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request May 27, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 8, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jun 24, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 3, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Jul 23, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 12, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 20, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Aug 22, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 1, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 4, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 14, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 19, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Sep 26, 2023
richard67 added a commit to richard67/joomla-cms that referenced this pull request Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants