Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Allowing menu items to have multiple 'rel' values #39269

Draft
wants to merge 7 commits into
base: 5.2-dev
Choose a base branch
from
Draft

[5.2] Allowing menu items to have multiple 'rel' values #39269

wants to merge 7 commits into from

Commits on Nov 21, 2022

  1. Making rel have multi select 

    Rel can have multiple values; we should allow that to happen.
    @crystalenka
    crystalenka committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    53f94f8 View commit details
    Browse the repository at this point in the history

  2. Missing rel values 

    Adding missing valid rel values per https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types
    @crystalenka
    crystalenka committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    4c60638 View commit details
    Browse the repository at this point in the history

  3. Check if value is array

    @crystalenka
    crystalenka committed Nov 21, 2022
    Configuration menu
    Copy the full SHA
    6120062 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Revert "Missing rel values" 

    This reverts commit 4c60638.
    @crystalenka
    crystalenka committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    bcf02fd View commit details
    Browse the repository at this point in the history

  2. Update modules/mod_menu/src/Helper/MenuHelper.php 

    Co-authored-by: ReLater <ReLater@users.noreply.github.com>
    @crystalenka @ReLater
    crystalenka and ReLater committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    71504ee View commit details
    Browse the repository at this point in the history

  3. Mirroring changes to admin url menu item

    @crystalenka
    crystalenka committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    746d7f1 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'menu-rel' of https://github.com/crystalenka/joomla-cms … 

    …into menu-rel
    @crystalenka
    crystalenka committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    55ffe08 View commit details
    Browse the repository at this point in the history