[5.2] Notification email on admin registration approval

[carlitorweb]

This is a rework for j4 of this PR #20282

Summary of Changes

The user who are manually actived will receive a notification by email informing his account has been activated.
There is also the option of being able to manually send a reminder email to the user even though the account is already activated (in case the user do not login in the page after X time)
The mail template used is com_users.registration.user.admin_activated

Testing Instructions

Apply the PR and after run npm run build:js -- build/media_source/com_users/js

1. Open the frontend and create a new user account
2. Open the User edit view inside the administration, and you will notice a new button in the toolbar
3. Use the button and check the user was actived and also a email sent to the email of the new user

• A email will be sent also if the user is actived in the Users list view using the Actions -> Active option

Actual result BEFORE applying this Pull Request

You can active a user, but not notification is sent.

Expected result AFTER applying this Pull Request

You can active a user, but a notification is sent.

Accept suggestions for:

• Button text
• Button icon
• Button color

Link to documentations

Please select:

• Documentation link for docs.joomla.org
  Page: Users:_Edit_Profile -> Document the new toolbar button
  Page: Users -> Here just need mention that active the user will send a email with the notification.

• No documentation changes for manual.joomla.org needed

[brianteeman]

/me dancing with joy

[brianteeman]

Looking good - two small issues

1. When using the new button I expected to get a message saying "the email has been sent" or something like that
2. The email that is sent is just the language keys not the values
   

Guessing that you need to copy the language strings from the site language file to the admin language file

[brianteeman]

or maybe the issue is that its not using the mail template

[carlitorweb]

My bad, I totally forgot the "mail sent" notification.

The other issue is weird, that worked for me in local. I will do a fresh Joomla install and check from there, maybe I had some changes made in the repo I was using...but still weird, somehow the mailer is not loading the strings..

I will check later this

[carlitorweb]

@brianteeman Okay you was right, the com_users.ini language loaded was only from the administrator part, as is expected.

So adding the follow:

// Load com_users site language strings
$language = $app->getLanguage();
$language->load('com_users', JPATH_SITE);

Fix the problem. But I really not like this solution. The best approch is just copy the strings to the administrator .ini language file. Is okay do it like this?

[brianteeman]

How do the other com_users admin emails do it?
Is it perhaps because you are not using the new mail templates?

[carlitorweb]

Is it perhaps because you are not using the new mail templates?

I using it, yes:

$mailer = new \Joomla\CMS\Mail\MailTemplate('com_users.registration.user.admin_activated', $app->getLanguage()->getTag());
$mailer->addTemplateData($mailData);
$mailer->addRecipient($userMail);

How do the other com_users admin emails do it?

They have all the string in the administrator .ini file

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[Sieger66]

I have tested this item ✅ successfully on f5cf34a

Works,
but the activated-email to the new user comes in the backend-language of the "Super User" who
click to the button"Activate & Send Email" or "Send Activation Reminder"-button,
and not in the default-language of the website as the registration-emails.

The registration-emails comes with this PR and without this PR in the default-language of the website.

default-language:
https://help.joomla.org/proxy?keyref=Help51:Languages:_Installed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[richard67]

Back to pending due to merge conflicts.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[brianteeman]

@richard67 how can this be RTC when we have this comment #39650 (comment)

[richard67]

@richard67 how can this be RTC when we have this comment #39650 (comment)

@brianteeman Why does @Sieger66 then post a successful test result if it is not successful?

@carlitorweb Is it intended that the email goes out in the backend language of the admin user?

[richard67]

Back to pending due to necessary clarification.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[brianteeman]

I can't speak for @Sieger66

What I have observed in other test reports is -" i tested this according to the instructions and it did what it said" but I also think

• its a bad idea
• its missing x
• y happens now

The current system doesnt really allow for that.

[carlitorweb]

Note: Remember when you install a new language and you want to use the mail template, is neccessary go to the Mail Template section, enter to the template you want to use and save it. Doing this, then the proper tag is generated in the language column of the mail_templates table. If not, always will fallback to en-GB

[Sieger66]

I have tested this item 🔴 unsuccessfully on b13a47a

After your last commit the com_users.registration.user.admin_activated - email comes only with the two language-Strings in the email:
in subject is only "COM_USERS_EMAIL_ACTIVATED_BY_ADMIN_ACTIVATION_SUBJECT"
in body is only "COM_USERS_EMAIL_ACTIVATED_BY_ADMIN_ACTIVATION_BODY"

Then i go to the Mail Template section to "com_users.registration.user.admin_activated" email-template
and click to save in german and english language version.(Only this two languages are installed in the website)
Now the com_users.registration.user.admin_activated - email comes with the correct text but ever in the english language in the email!
The default-language of the website and the "administrator backend-language" have no affect to the language in this email.
I think that is not correct.

All other "registration-emails" for example:
com_users.registration.user.admin_activation
com_users.registration.admin.verification_request
comes in the default-language of the website.

default-language:
https://help.joomla.org/proxy?keyref=Help51:Languages:_Installed

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[carlitorweb]

@Sieger66 We have 2 default language param, one is for the administrator and the other is for the frontend. Right now, the email go out with the default language of the administrator.

If I understand well, what you looking for is, the email go out with the default language of the frontend, is this correct?

[Sieger66]

Yes, this is correct.
Ohh! I now see the default-language param for the administrator and
the email go out with the default language of the administrator.
In detail the "com_users.registration.user.admin_activated" email comes allways with this language with your last commit.
But the other emails comes in the language of the default-language param for the site.

I dont know is it intended and is it correct usecase.

Other small issue:
In the sent notification message in backend comes only the language-key:
COM_USERS_REGISTRATION_ACTIVATION_NOTIFY_SEND_MAIL_SUCCESS
and not the value(text).

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}

[carlitorweb]

@Sieger66 issue fixed

Now the email will go out with the site default language.

[Sieger66]

I have tested this item ✅ successfully on c375030

Works as aspected.
@brianteeman : Now we need a second test.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39650.}