Fixes various code style issues and integrate PHP CS Fixer into drone #39745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laoneo
requested review from
chmst,
bembelimen,
HLeithner,
rdeutz,
Hackwar and
wilsonge
as code owners
4 tasks
HLeithner
reviewed
Jan 30, 2023
HLeithner
requested changes
Jan 30, 2023
administrator/components/com_config/src/Controller/ComponentController.php
Outdated
Show resolved
Hide resolved
administrator/components/com_content/src/Controller/ArticleController.php
Outdated
Show resolved
Hide resolved
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The https://github.com/PHP-CS-Fixer/PHP-CS-Fixer project is another code style fixer for PHP which we have a config for since #10992 but actually never used. This pr integrates it into drone and fixes the code base, primarily adding a trailing comma on multiline arrays where phpcs has a big weakness.
On the other side the PHP CS Fixer can't properly handle files where HTML syntax is mixed with PHP code, so it makes sense to use both projects in our CI pipeline.
This pr is a result from #39739 (review).
This can be merged by review.