Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3][Guided Tours] Change URL label #40119

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Conversation

Quy
Copy link
Contributor

@Quy Quy commented Mar 14, 2023

Partial fix for Issue #40020, #40021 .

Summary of Changes

Change URL label to Relative URL to indicate relative and not absolute URL without having to read the inline help.

Testing Instructions

Edit a tour.
See URL label.
Edit a step.
Change Type to Redirect.
See URL label.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Mar 14, 2023
@Hackwar Hackwar added the bug label Apr 8, 2023
@khu5h1
Copy link
Contributor

khu5h1 commented Jul 7, 2023

I have tested this item ✅ successfully on 5403f50

Code Review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40119.

@obuisard
Copy link
Contributor

I have tested this item ✅ successfully on 5403f50


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40119.

@obuisard obuisard added this to the Joomla! 4.3.4 milestone Aug 10, 2023
@Quy Quy removed Language Change This is for Translators bug labels Aug 10, 2023
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 4.3.4 milestone Aug 10, 2023
@Quy
Copy link
Contributor Author

Quy commented Aug 10, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40119.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 10, 2023
@Quy Quy added this to the Joomla! 4.3.4 milestone Aug 10, 2023
@joomla-cms-bot joomla-cms-bot added the Language Change This is for Translators label Aug 10, 2023
@sdwjoomla sdwjoomla merged commit 99b34ba into joomla:4.3-dev Aug 11, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 11, 2023
@sdwjoomla
Copy link
Contributor

Thanks @Quy

@brianteeman
Copy link
Contributor

i thought we didnt change language strings in a patch release?

@Quy Quy deleted the relative-url branch August 11, 2023 14:14
Kostelano added a commit to JPathRu/localisation that referenced this pull request Aug 20, 2023
Новое в Joomla 4.3.3 Stable
* joomla/joomla-cms#40637 +
* joomla/joomla-cms#40698 - (исправлено ранее)
* joomla/joomla-cms#40716 - (только для en-GB)
* joomla/joomla-cms#40732 +
* joomla/joomla-cms#40607 +

Новое в Joomla 4.3.4 Stable
* joomla/joomla-cms#40449 +
* joomla/joomla-cms#40119 +
* joomla/joomla-cms#40297 +
* "Вход на сайт", но "Выход из системы" - разброс формулировок исправлен на термин "система", подразумевая именно вход/авторизацию пользователя, а не просто серфинг страницы сайта без авторизации
* Другие мелкие исправления
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants