[4.4] Category Item count takes publish dates into account

[hendrikbehncke]

Summary of Changes

Item count on a category takes the publish_up and publish_down dates into account.

Actual result BEFORE applying this Pull Request

When setting a publish_down date in the past to unpublish an article the item count on a category will still count this article as published. And vice versa with a publish_up date in the future. The Categories view shows a different amount of articles than actually visible on the Category Blog view

Expected result AFTER applying this Pull Request

Categories view will show the exact number of articles published in a category.

[richard67]

Can we be really sure that all tables $this->_table used here

joomla-cms/libraries/src/Categories/Categories.php

Line 341 in 7c3d332

->from($db->quoteName($db->escape($this->_table), 'i'))

have publish_up and publish_down columns? If that table doesn't have these columns, we will get an SQL error about an unknown column when executing the SQL statement which is extended by this PR.

[Denitz]

It will frustrate a user: you will see X published articles but if you click the red counter and navigate to article list with &filter[published]=0 filter you will see no articles because they are actually published (#__content.state = 1).

Not a good idea. Either skip it or implement a separate counter of smth like "currently unpublished" items.

[hendrikbehncke]

Hi @richard67, that could indeed be an issue.
Maybe passing the fields in the options in components/com_content/src/Service/Category.php could solve this?

Or alternatively people use 3rd party plugins to automatically update the published flag depending on the publish_up and publish_down dates.

[HLeithner]

This pull request has been automatically rebased to 4.4-dev.