[4.4] Update deleted files list in script.php for 4.4.0-alpha1 #40231
Conversation
|
I have tested this item ✅ successfully on 7ff03ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40231. |
|
Your instructions are very readable 👍 I will take a look. |
|
I have tested this item ✅ successfully on 898e85a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40231. |
|
I guess this one should be changed to draft so people are not testing it. It will then be merged before we ship the first alpha. |
@laoneo I would prefer not to wait with merging until just before alpha because people might test the nightly builds, too, which could show us if we make mistakes with that. In the mean time I would check when PR's have been merged and make a new PR when I see there is again a bunch of deleted files. Of course if my PR's of this kind will be merged anyway by review, I can set it to draft so people don't waste time with testing. On the other hand, a test is never bad. |
|
Missing in list, see #40173 'plugins/sampledata/testing/src/Extension/Testing.php' |
|
@sandewt Yes, and others might follow. I have a tool which I run periodically and then update this PR as long as not merged yet. Will maybe later change it to draft status. No need for testing now. But thanks so far. |
My pleasure, I hear |
|
@sandewt Ah, sorry, I forgot: The testing sample data plugin is something which we only have in development environments, i.e. git clones. But we don't have that in the regular (alpha or beta or rc or stable releases) installation packages and also not in nightly builds. That's why it will not go into the list of deleted files and folders, and we will not delete that file on update. So nothing to do for that file "plugins/sampledata/testing/testing.php" from PR #40173 . |
|
@laoneo The PR is still up to date, so if you want I can change it back from draft to ready and you can merge, and the next PR I make after another bunch of merged relevant PRs. |
laoneo
added
the
Updates Requested
|
@laoneo Why have you added the Updates Requested label? I see no change request in any review so that label does not make any sense for this PR. |
|
Because they need some updates when we merge further prs which remove files. I want to make sure that people are not wasting their time testing these pr's. |
@laoneo This is not what thatblabel has been made for. It has been made for PRs where maintainers request changes. Tjisbis not the case here. |
laoneo
removed
the
Updates Requested
|
I have it removed. |
|
@laoneo Sorry for my possibly too harsh words, I was unnecessarily too upset. I understand what you wanted to achieve with setting that label, and if you insist on it I will put this PR back to draft status. But I think we should not wait with merging it until short before alpha 1, I think we should merge it soon so we and other people can test updating older versions to 4.4-dev nightly builds with the old files of plugins and modules being removed at the update so we can see if we have issues with that on particular environments. |
|
@richard67 If anythng the files should be added to the scrript with the pr to ensure there is no delay. like they used to be |
|
I would wait till the last plugin conversions are merged. @MacJoom is on it. And then we can merge this one. |
|
@laoneo This PR here is ready and up to date. |
|
Thanks! |
Pull Request for Issue # .
Summary of Changes
This pull request (PR) updates the list of files to be deleted on update in file "administrator/components/com_admin/script.php" to recent changes in the 4.4-dev branch in preparation for the first 4.4.0-alpha1 release.
In detail deleted files from following PR's are added:
'/modules/mod_footer/mod_footer.php',
'/modules/mod_users_latest/mod_users_latest.php',
'/plugins/content/pagenavigation/pagenavigation.php',
'/plugins/installer/folderinstaller/folderinstaller.php',
'/plugins/installer/override/override.php',
'/plugins/installer/packageinstaller/packageinstaller.php',
'/plugins/installer/urlinstaller/urlinstaller.php',
'/plugins/installer/webinstaller/webinstaller.php',
'/plugins/privacy/actionlogs/actionlogs.php',
'/plugins/privacy/consents/consents.php',
'/plugins/privacy/contact/contact.php',
'/plugins/privacy/content/content.php',
'/plugins/privacy/message/message.php',
'/plugins/privacy/user/user.php',
'/plugins/user/contactcreator/contactcreator.php',
'/plugins/user/joomla/joomla.php',
'/plugins/user/profile/profile.php',
'/plugins/user/terms/terms.php',
'/plugins/user/token/token.php',
'/modules/mod_articles_category/mod_articles_category.php',
'/modules/mod_articles_archive/mod_articles_archive.php',
'/plugins/media-action/crop/crop.php',
'/plugins/media-action/resize/resize.php',
'/plugins/media-action/rotate/rotate.php',
'/plugins/sampledata/blog/blog.php',
'/plugins/sampledata/multilang/multilang.php',
'/modules/mod_articles_categories/mod_articles_categories.php',
'/modules/mod_custom/mod_custom.php',
'/modules/mod_related_items/mod_related_items.php',
'/modules/mod_breadcrumbs/mod_breadcrumbs.php',
'/plugins/system/accessibility/accessibility.php',
'/plugins/system/actionlogs/actionlogs.php',
'/plugins/system/debug/debug.php',
'/plugins/system/fields/fields.php',
'/plugins/system/highlight/highlight.php',
'/plugins/system/httpheaders/httpheaders.php',
'/plugins/system/jooa11y/jooa11y.php',
'/plugins/system/languagecode/languagecode.php',
'/plugins/system/languagefilter/languagefilter.php',
'/plugins/system/log/log.php',
'/plugins/system/logout/logout.php',
'/plugins/system/logrotation/logrotation.php',
'/plugins/system/privacyconsent/privacyconsent.php',
'/plugins/system/redirect/redirect.php',
'/plugins/system/remember/remember.php',
'/plugins/system/schedulerunner/schedulerunner.php',
'/plugins/system/sef/sef.php',
'/plugins/system/sessiongc/sessiongc.php',
'/plugins/system/skipto/skipto.php',
'/plugins/system/stats/stats.php',
'/plugins/system/tasknotification/tasknotification.php',
'/plugins/system/updatenotification/updatenotification.php',
'/plugins/content/finder/finder.php',
'/plugins/content/joomla/joomla.php',
'/plugins/content/loadmodule/loadmodule.php',
'/plugins/content/pagebreak/pagebreak.php',
'/plugins/content/vote/vote.php',
'/plugins/webservices/banners/banners.php',
'/plugins/webservices/config/config.php',
'/plugins/webservices/contact/contact.php',
'/plugins/webservices/content/content.php',
'/plugins/webservices/installer/installer.php',
'/plugins/webservices/languages/languages.php',
'/plugins/webservices/media/media.php',
'/plugins/webservices/menus/menus.php',
'/plugins/webservices/messages/messages.php',
'/plugins/webservices/modules/modules.php',
'/plugins/webservices/newsfeeds/newsfeeds.php',
'/plugins/webservices/plugins/plugins.php',
'/plugins/webservices/privacy/privacy.php',
'/plugins/webservices/redirect/redirect.php',
'/plugins/webservices/tags/tags.php',
'/plugins/webservices/templates/templates.php',
'/plugins/webservices/users/users.php',
'/plugins/workflow/featuring/featuring.php',
'/plugins/workflow/notification/notification.php',
'/plugins/workflow/publishing/publishing.php',
Testing Instructions
Code review.
Or if you want to make a real test, update a 4.3.0-rc1 or recent 4.3 nightly build to the last 4.4 nightly build to get the actual result, and update a 4.3.0-rc1 or recent 4.3 nightly build to the update package built by Drone for this PR to get the expected result.
Actual result BEFORE applying this Pull Request
The files mentioned above are still present after updating from a 4.3.0-rc1 or recent 4.3 nightly build.
Expected result AFTER applying this Pull Request
The files mentioned above have been deleted after updating from a 4.3.0-rc1 or recent 4.3 nightly build.
Link to documentations
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed