Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Replace JPATH_PLATFORM with _JEXEC in plugin code #40232

Merged
merged 6 commits into from
Mar 29, 2023

Conversation

sandewt
Copy link
Contributor

@sandewt sandewt commented Mar 29, 2023

Pull Request for Issue # .

Summary of Changes

The constant JPATH_PLATFORM is a history thing and should not be used in the plugin code
This pr replaces this with _JEXEC , and makes the code consistent with that of the other plugins.

Related to #39997

Testing Instructions

  • Works
  • Code review

Actual result BEFORE applying this Pull Request

Code: \defined('JPATH_PLATFORM') or die;

Expected result AFTER applying this Pull Request

Code: \defined('_JEXEC') or die;

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@laoneo please take a look

@laoneo
Copy link
Member

laoneo commented Mar 29, 2023

Just wondering, do we have more occurrences of JPATH_PLATFORM or are these the last ones?

@sandewt
Copy link
Contributor Author

sandewt commented Mar 29, 2023

Just wondering, do we have more occurrences of JPATH_PLATFORM or are these the last ones?

I have checked the plugin code in Joomla 4.4. The modules (site) are up to date.

I assume the libraries folder is not applicable. Is this correct?

If yes, then there are still about 24 in the folder \administrator\components...

@rdeutz
Copy link
Contributor

rdeutz commented Mar 29, 2023

Good idea, looks ok to me

@laoneo
Copy link
Member

laoneo commented Mar 29, 2023

So we can do in a followup pr a replacement of all JPATH_PLATFORM...

@laoneo laoneo merged commit aecd8e4 into joomla:4.4-dev Mar 29, 2023
@laoneo
Copy link
Member

laoneo commented Mar 29, 2023

Thanks!

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Mar 29, 2023
@sandewt
Copy link
Contributor Author

sandewt commented Mar 29, 2023

Thanks all

@sandewt sandewt deleted the patch-10 branch April 26, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants