Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.3] Guided Tours improvement search label #40299

Merged
merged 3 commits into from
May 6, 2023

Conversation

heelc29
Copy link
Contributor

@heelc29 heelc29 commented Apr 2, 2023

Summary of Changes

More meaningful label of search field for tours and step link e.g. for articles:

COM_CONTENT_FILTER_SEARCH_LABEL="Search Articles"

Testing Instructions

Check label of search input for tours and steps

<div class="input-group">
    <input type="text" name="filter[search]" id="filter_search" value="" class="form-control" aria-describedby="filter_search-desc" placeholder="Search" inputmode="search">
    <div role="tooltip" id="filter_search-desc" class="filter-search-bar__description">
        Search in title. Prefix with ID: to search for a tour ID or DESCRIPTION: to search in description.
    </div>
    <span class="filter-search-bar__label visually-hidden">
        <label id="filter_search-lbl" for="filter_search">
            Search Tours
        </label>
    </span>
    <button type="submit" class="filter-search-bar__button btn btn-primary" aria-label="Search">
        <span class="filter-search-bar__button-icon icon-search" aria-hidden="true"></span>
    </button>
</div>

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.3-dev labels Apr 2, 2023
@Quy
Copy link
Contributor

Quy commented Apr 2, 2023

I have tested this item ✅ successfully on 945512f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

1 similar comment
@khu5h1
Copy link
Contributor

khu5h1 commented Apr 3, 2023

I have tested this item ✅ successfully on 945512f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40299.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 3, 2023
@Hackwar Hackwar added the bug label Apr 8, 2023
@obuisard obuisard added this to the Joomla! 4.3.2 milestone May 6, 2023
@obuisard obuisard merged commit 70c2915 into joomla:4.3-dev May 6, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 6, 2023
@obuisard
Copy link
Contributor

obuisard commented May 6, 2023

Thanks @heelc29 :-)

@heelc29 heelc29 deleted the 4.3/com_guidedtours/search-label branch May 7, 2023 08:35
Kostelano added a commit to JPathRu/localisation that referenced this pull request Jun 1, 2023
В Joomla 4.3.1 не было изменений в локализации.

Новое в Joomla 4.3.2 Stable
joomla/joomla-cms#40258 +
joomla/joomla-cms#40266 - (только для en-GB)
joomla/joomla-cms#40471 - (только для en-GB)
joomla/joomla-cms#40304 +
joomla/joomla-cms#40401 - (только для en-GB)
joomla/joomla-cms#40299 - (только для en-GB)
joomla/joomla-cms#40539 +
joomla/joomla-cms#40377 +
joomla/joomla-cms@0b162d3 + (коммит без PR)
+ другие мелкие исправления
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants