-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding profile display test (com_users). #40370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/joomla-cms into ProfileDisplayTest
laoneo
reviewed
Apr 12, 2023
tests/System/integration/site/components/com_users/Profile_display.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Apr 12, 2023
tests/System/integration/site/components/com_users/Profile_display.cy.js
Outdated
Show resolved
Hide resolved
laoneo
reviewed
Apr 12, 2023
tests/System/integration/site/components/com_users/Profile_display.cy.js
Outdated
Show resolved
Hide resolved
Looks good, just a minor comment. can you do that then for the menu item test as well? |
Can you remove the _display part from the filename and do the check with a different username. How it is now, you are testing the name with the username test. |
…/joomla-cms into ProfileDisplayTest
Thank you for bringing this to my attention; I have now corrected it. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #
Adding user profile display test.