Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding profile display test (com_users). #40370

Merged
merged 17 commits into from
Apr 12, 2023

Conversation

charvimehradu
Copy link
Contributor

Pull Request for Issue #

Adding user profile display test.

@charvimehradu charvimehradu changed the base branch from 4.3-dev to 4.4-dev April 11, 2023 21:46
@laoneo laoneo removed the PR-4.3-dev label Apr 12, 2023
@laoneo laoneo self-assigned this Apr 12, 2023
@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 12, 2023
@laoneo
Copy link
Member

laoneo commented Apr 12, 2023

Looks good, just a minor comment. can you do that then for the menu item test as well?

@laoneo
Copy link
Member

laoneo commented Apr 12, 2023

Can you remove the _display part from the filename and do the check with a different username. How it is now, you are testing the name with the username test.

@charvimehradu
Copy link
Contributor Author

Thank you for bringing this to my attention; I have now corrected it.

@laoneo laoneo added this to the Joomla! 4.4.0 milestone Apr 12, 2023
@laoneo laoneo merged commit e004f3a into joomla:4.4-dev Apr 12, 2023
@laoneo
Copy link
Member

laoneo commented Apr 12, 2023

Thanks!

@laoneo laoneo removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants