[4.3] Backporting changes from framework Input/Cookie class to CMS class #40414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on e33f299 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40414. |
|
Adding screen shot for the cookie being 1 year out. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40414. |
|
I have tested this item ✅ successfully on e33f299 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40414. |
|
Thank you for this patch. Super 👍🏽😊🙏🏽 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40414. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/40414. |
|
Thank you Hannes @Hackwar for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #40412 .
Summary of Changes
This PR backports several bugfixes from the frameworks Input/Cookie class to the CMS class, making the classes compatible. This fixes the issue of the languagefilter not being able to set the cookie. The original issue is, that our base class for our application, AbstractWebApplication, defines the Input object as the framework class, while the child classes use the CMS class instead.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed