Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Fix bootstrap.js when debug is On #41043

Merged
merged 2 commits into from
Jun 25, 2023
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Jun 25, 2023

Pull Request for Issue # .

Summary of Changes

Fix bootstrap js error when debug is On, caused by changes in #39618

Testing Instructions

Apply patch, run npm install
Enable debug mode. Check browser console.

Actual result BEFORE applying this Pull Request

JS error "bootstrap not found" and other errors

Expected result AFTER applying this Pull Request

No errors, all works

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

ref #39618

@Fedik Fedik added the bug label Jun 25, 2023
@Fedik Fedik changed the title [5.0] Fix bootstrap when debug is On [5.0] Fix bootstrap.js when debug is On Jun 25, 2023
@richard67
Copy link
Member

JS error "bootstrap not found" and other errors

One of the other errors is that dropdowns at the top of the backend like e.g. the "User" dropdown for logging out do not work.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6408f94


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41043.

@richard67
Copy link
Member

I've set the "Release Blocker" label since essential things like dropdowns are broken in 5.0-dev without this fix.

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 6408f94

Probably the root is different but let’s merge this rn and investigate this later


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41043.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41043.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 25, 2023
@HLeithner HLeithner enabled auto-merge (squash) June 25, 2023 13:34
@HLeithner
Copy link
Member

thanks

@HLeithner HLeithner disabled auto-merge June 25, 2023 16:00
@HLeithner HLeithner merged commit 7db61ae into joomla:5.0-dev Jun 25, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 25, 2023
@Fedik Fedik deleted the Fedik-patch-2 branch June 25, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants