-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.2] Enhance translation "Empty trash" #41119
base: 5.2-dev
Are you sure you want to change the base?
Conversation
Is |
TBH - I have no opinion here, only want to get rid of the "empty trash". |
I am not too concerned about the selection. For me there is nothing wrong with the current text. We put items in the trash (by changing the state) That is the same language construct used in windows |
Speaking for me: Edit:
Windows does what I use to do with the bin "empty trash" == Empty completely. |
Interesting feature :) Changing the language string to "delete" is easy, of course. If we are following the windows behaviour we must have: This is a big action, as all our backend views are concerned. |
Which is why its never been done before. it is also a potentially big b/c break for 3pd |
For me the problem is not the text, instead the way to get there, 9 clicks to delete an item is the problem not if it's called "empty trash" or "delete" or "burn it down the house". Edit: it's 9 clicks instead of 7 |
suggestions remove the requirement to select an item before the empty trash button is active. if nothing is selected then everything is deleted. if something is selected then just delete the selected items remove the "are you sure" confirmation. going from published to trashed should be enough of an opportunity to change your mind without being asked again |
Additional to brians suggestions: |
@HLeithner fully agree. But not in scope here :) |
I tried to write that some time ago but my code was not good.
if that is possible then great - not something I have seen in a web ui before |
This is a developer solution but I am advocate of normal users, I doubt if this is self-explaining and a11y ? |
it's basically the same as the joomla shortcuts, something like this: document.querySelector('body').addEventListener("keydown", (e) => {
if (e.key === "Shift") {
result.innerText = "Shift Key Pressed";
}
});
document.querySelector('body').addEventListener("keyup", (e) => {
if (e.key === "Shift") {
result.innerText = "Shift Key Not Pressed";
}
}); |
you can explain it in a guided tour, but it's also only an additonal way |
Removing the "are you sure" is a simple one line change in each component for example delete this line
Making the button deleteAll without having selected anything is a bigger change as that is in the library |
I love this PR, It confuses so much of my customers that its called Empty trash but does not do it |
Changing the meaning of a language string is a b/c break and not allowed at all per policy if we like to use "Delete" as string instead of "Empty Trash" then we need a new language string and use this one. Also "Delete Permanently" is redundant language as mentioned by @Quy |
This pull request has been automatically rebased to 5.1-dev. |
I have tested this item ✅ successfully on 500df90 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
1 similar comment
I have tested this item ✅ successfully on 500df90 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
This should not be RTC
|
Back to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
Yes please create a new translation string, and make it simple, maybe use "Nuke" ;-) |
I have tested this item ✅ successfully on 500df90 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
1 similar comment
I have tested this item ✅ successfully on 500df90 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
@chmst is that still up to date? Any plans for 5.1? |
I have tested this item ✅ successfully on 500df90 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41119. |
This pull request has been automatically rebased to 5.2-dev. |
Pull Request for Issue #41106 .
Replacement of #41116.
Summary of Changes
Replace the text "Empty trash" as proposed in #41106.
Testing Instructions
Check a trash can before and after patch
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed