Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Fix Joomla.renderMessages not found with mod_login #41300

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Aug 1, 2023

Pull Request for Issue #41299 .

Summary of Changes

Add missing dependency for Joomla.renderMessages

Testing Instructions

Please follow #41299

Actual result BEFORE applying this Pull Request

JS error

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@Fedik Fedik added bug Small A PR which only has a small change labels Aug 1, 2023
@wilsonge wilsonge added the Maintainers Checked Used if the PR is conceptional useful label Aug 1, 2023
@Hackwar Hackwar added the PBF Pizza, Bugs and Fun label Aug 25, 2023
@ceford
Copy link
Contributor

ceford commented Sep 25, 2023

I can't reproduce this problem. I have Multi-factor Authentication is not enabled. I have registered my Authenticator in W3C Web Authentication (WebAuthn) Login. In the Admin login form I click the button on the dongle when prompted and login works normally. With a user not using that method there is a normal error message. Everything I see is translated. I do not see any Javascript error messages.

Perhaps some more specific test instructions would help. I am using joomla-cms with 4.3-dev checked out and Chrome/Firefox on Mac.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

@ceford
Copy link
Contributor

ceford commented Sep 25, 2023

Same with frontend login - no problems.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

@HLeithner HLeithner changed the base branch from 4.3-dev to 4.4-dev September 30, 2023 22:43
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 4.4-dev.

@TLWebdesign
Copy link

I have tested this item 🔴 unsuccessfully on e67eb16

Could not reproduce the Javascript error in the console on failed login. My method:
Create user with a valid webauthn setup.
Check that login works for this user on the front-end using the mod_login form.
Log the user out in front-end.
Remove the webauthn setup for this user.
Reload page.
Try to login again as webauth for this user.
No Javascript errors in console. Only an formatted error message is displayed: "The credential ID is invalid." So It is rendering the message just fine.
Joomla 4.4.3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41300.

@HLeithner HLeithner changed the title Fix Joomla.renderMessages not found with mod_login [4.4] Fix Joomla.renderMessages not found with mod_login Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Maintainers Checked Used if the PR is conceptional useful PBF Pizza, Bugs and Fun PR-4.4-dev Small A PR which only has a small change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants