[5.3] Batch Copy & Move tags

[beni71]

Pull Request for Issue #23304, only partially.
This PR is based on #38583 and fixes the comments.

Summary of Changes

Adds the ability to batch copy/move tags in the tags list.
Copying a tag also copies its children (same behavior as in other tree models like categories, menues).
Moving a tag also moves its children (same behavior as in other tree models like categories, menues).
For example, it is possible to move a child tag from one parent to another (including its children), or to copy a child tag from one parent to another (including its children).
In the batch tag drop down there is also an item "Root" to move/copy selected tags to the root level.

Changed visualization "Action to Perform" of copy/move action, it is now hidden as long as the user does not touch the select field for copy/move. See example in video below. This change affects batch copy/move dialog of menues and articles as well.

It also fixes a browser console error when the batch dialog is opened and cancel is clicked, on systems where multilingual is disabled.

Testing Instructions

It contains an updated javascript so run: npm run build:js

Initial tag structure for each of the tests below:
Tag1
-Tag2
--Tag3
Tag4

Test 1
Move Tag2 to Tag4 results in:
Tag1
Tag4
-Tag2
--Tag3

Test 2
Move Tag1 to Tag4 results in:
Tag4
-Tag1
--Tag2
---Tag3

Test 3
Copy Tag4 to Tag2 result in:
Tag1
-Tag2
--Tag3
--Tag4 (2)
Tag4

Test 4
Check whether the visualization of "Action to Perform" of copy/move action is first hidden for views like menues, articles. Only if a target item is selected "Action to Perform" appears.

Actual result BEFORE applying this Pull Request

The tags list batch processing does not support copy move.

Expected result AFTER applying this Pull Request

The tags list batch processing supports copy move:

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[ceford]

I have tested this item ✅ successfully on c503b03

Easy to get into a muddle but works as described.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.}

[chmst]

Thanks a lot for working on this issue! Unfortunately I am not in favour of this implementation, from UX point of view.
Batch copy and move is not quite easy to understand, but at least the process should be everywhere the same. Behavoiur must be predictable.
Would it be possible to implement this behaviour "as always"?

Always:

user selects an item in the list and activates the batch button
(the system has the ids of the selected items)

on the modal: the users selects a target for his copy or move from the dropdown

decides if the action copy or move is to be performed.

your implementation

user selects an item in the list and activates the batch button (as he uses to do in other places)
(the system ignores the selection)

The "keep original tag" is misleading. The user's selection in the list is ignored, he must select the items now in the dropdown list.

After the selection of an item from the list, the select is replaced by another question. This change is so fast and the texts look similiar that it is difficult to notice the replacement. The user could think that he still sees his selection.

It would be clearer if the new block is appended to the first one.

The process then works like a charm.

I think that this causes confusion

In my opinion, the process should be the same in all categories and all other components, then it does not need extra documentation.

[brianteeman]

@chmst isnt this identical to the ui for batch copying and moving menu items??

[chmst]

@brianteeman not if I understand this correctly

You choose a menuitem in the list (the systems holds the id), opens the batch modal

then you choose a target menuitem and decides if you want a copy or move.

You must not do this first step and select your item in the batch modal.

[brianteeman]

I dont see the difference

I think the confusion is because the language string is wrong
it should not be Keep Original Tags
it should be Dont Copy or move

[chmst]

Yes, thanks for explainingt. The language string is the first reason for confusion. But it must be "select a tag". Just open the dropdown.

The second is: Why not accept the selection of items to move or copy from the overview? In com_menus and in categories we don't have an extra step for that. Maybe there is something special in tags which requires that?

[brianteeman]

@chmst Sorry I dont understand what you are talking about

[chmst]

I am sorry that I cannot explain. Will try it later with videos.

[chmst]

@brianteeman you were correct. - it seems that this language string caused the whole confusion and my folloing action was overreaction.
So it will be an easy fix. Thanks for your patience.

[beni71]

Sorry for that confusion. I fixed the text and updated the description part of the PR.

[HLeithner]

This pull request has been automatically rebased to 5.1-dev.

[beni71]

Extended the batch tag drop down with a "Root" item to move/copy selected tags to the root level, suggested by @adj9.
I updated the description.

[beni71]

@bembelimen Can you please tell me where the breaking change is? Do I need to fix it?

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[cybersalt]

I have tested this item 🔴 unsuccessfully on 715e848

The copy and move radio buttons did not show up for me.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.}

[alikon]

did you run: npm run build:js first ?

[fgsw]

Download Prebuilt packages result in a 404.

@Quy Thanks solving Problem.

[fgsw]

I have tested this item ✅ successfully on 715e848

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.}

[bascherz]

I have tested this item 🔴 unsuccessfully on 715e848

The Copy/Move radio buttons do not appear. The action performed is Move.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.}

[cybersalt]

I have tested this item 🔴 unsuccessfully on 715e848The copy and move radio buttons did not show up for me.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.

I just learned what an NPM patch is and that it can't be tested through the patchtester as I was using it on a copy of my live site on the server. So please disregard my failed test!

[obuisard]

I have tested this item 🔴 unsuccessfully on 715e848The Copy/Move radio buttons do not appear. The action performed is Move.

Bruce @bascherz, did you use the patch tester extension for your tests? Pull requests that are tagged 'NPM Resource Changed' need to be tested locally, they cannot be tested straight from our PBF instances, unfortunately. That's because a script file has been modified and the Joomla instance needs to be rebuilt to be able to get tested.

[fgsw]

I just learned what an NPM patch is and that it can't be tested through the patchtester

@cybersalt you can use instead a prebuilt package. Download at the end of this pull request.

So please disregard my failed test!

if you don't test again you can set back the test result at the issue tracker by "Test this > Not tested".

[cybersalt]

I have not tested this item.

My Pizza Bugs and Fun test was first marked as a fail, but then I learned that I could not test this one with the patch tester - so I am resetting this to "not tested" so as to not confuse things.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41927.}

[HLeithner]

This pull request has been automatically rebased to 5.3-dev.