[4.4] FIX calendar picker if weeknumbers hidden and time format 24h #42185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue introduced (by me 馃 ) in PR #40761.
Affected Joomla versions: 4.4.0 and 5.0.0
Summary of Changes
Quick FIX : Time select broken if calendar form field has
weeknumbers
attribute onfalse
.Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).
Testing Instructions
Set 2 form fields of type calendar like this (with and without week numbers):
Note: default timeformat is 24 and default weeknumbers is true.
Actual result BEFORE applying this Pull Request
You can't change Time (hour and/or minutes) with the
no_week_numbers
calendar picker.It's working with the other form field.
Expected result AFTER applying this Pull Request
It's working in both cases.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed