Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] FIX calendar picker if weeknumbers hidden and time format 24h #42185

Open
wants to merge 3 commits into
base: 4.4-dev
Choose a base branch
from

Conversation

cyrezdev
Copy link
Contributor

@cyrezdev cyrezdev commented Oct 20, 2023

Pull Request for Issue introduced (by me 馃 ) in PR #40761.

Affected Joomla versions: 4.4.0 and 5.0.0

Summary of Changes

Quick FIX : Time select broken if calendar form field has weeknumbers attribute on false.

Check if weeknumbers is true or false to listen to correct number of childNodes.
Calendar form field with 12h (AM/PM) time format is not affected by the issue, as well as calendar picker with week numbers (so Joomla core not affected).

Testing Instructions

Set 2 form fields of type calendar like this (with and without week numbers):

Note: default timeformat is 24 and default weeknumbers is true.

<field
	name="no_week_numbers"
	type="calendar"
	label="Test"
	description="Test without weeknumbers and time 24h"
	showtime="true"
	weeknumbers="false"
/>

<field
	name="week_numbers"
	type="calendar"
	label="Test"
	description="Test with weeknumbers and time 24h"
	showtime="true"
/>

Actual result BEFORE applying this Pull Request

You can't change Time (hour and/or minutes) with the no_week_numbers calendar picker.
It's working with the other form field.

Expected result AFTER applying this Pull Request

It's working in both cases.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 added the bug label Oct 20, 2023
@HLeithner HLeithner changed the title FIX calendar picker if weeknumbers hidden and time format 24h [4.4] FIX calendar picker if weeknumbers hidden and time format 24h Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants