Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Access level registered for mod_user #42254

Open
wants to merge 5 commits into
base: 4.4-dev
Choose a base branch
from

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Oct 31, 2023

Pull Request for Issue #28804 .

Summary of Changes

Remove rendering status modules from login, Set accesslevel "registered" for mod menu

Testing Instructions

Grant access to the backend for a usergroup which has not viewlevel "special", for example to usergroup registered.
The user then can login to the backend.

Actual result BEFORE applying this Pull Request

He cannot log out

Expected result AFTER applying this Pull Request

Set access-level for mod_user to "registered" or make a fresh installation for a new test.
mod_user is active, the user can log out.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

chmst and others added 2 commits October 31, 2023 10:01
…3-10-31.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
…0-2023-10-31.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
@brianteeman
Copy link
Contributor

Is it intended top remove the link to the frontend of the site from the login page?

@chmst chmst changed the title Access level registered for com_user Access level registered for mod_user Nov 2, 2023
@HLeithner
Copy link
Member

I think we can't hard code access level ids in sql statements (there is no guarantee that 2 === registered)

Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said above sql updates can't use hardcoded access levels

@HLeithner HLeithner added the bug label Nov 23, 2023
@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Nov 23, 2023
@carlitorweb
Copy link
Member

Should not be enough for this module to appear that the user have access to the administrator? How I see it, this module do not need to proccess any access level to see if he can or not show up in that position. If you log in, you need a way to log out and you don't need an access level to define it.

@HLeithner HLeithner changed the title Access level registered for mod_user [4.4] Access level registered for mod_user Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-4.4-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants