Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] com_contact remove showon when useglobal is used in the field #42386

Closed
wants to merge 3 commits into from

Conversation

drmenzelit
Copy link
Contributor

Pull Request for Issue #42381 .

Summary of Changes

Removed the showon option in several fields

Testing Instructions

See issue #42381

Actual result BEFORE applying this Pull Request

Showon fields are not displayed in contact and menu item if the "parent" field has useglobal

Expected result AFTER applying this Pull Request

Showon fields are displayed

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

maybe it's better to fix the real issue if the issue is true for all global based showOns ?

@HLeithner HLeithner added the bug label Nov 23, 2023
@drmenzelit
Copy link
Contributor Author

maybe it's better to fix the real issue if the issue is true for all global based showOns ?

Yes ;-) useglobal inserts a new select option but without value ... do you know where that is created?

@bembelimen bembelimen changed the base branch from 5.0-dev to 5.1-dev March 14, 2024 08:59
@crimle
Copy link

crimle commented Apr 5, 2024

I have tested this item ✅ successfully on 441e2f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

@MacJoom
Copy link
Contributor

MacJoom commented Apr 5, 2024

I have tested this item ✅ successfully on 441e2f1

Tested on 5.1.0 RC1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

@Quy Quy added PR-5.0-dev and removed PR-5.1-dev labels Apr 5, 2024
@Quy
Copy link
Contributor

Quy commented Apr 5, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2024
@Quy Quy added PR-5.1-dev and removed PR-5.0-dev labels Apr 5, 2024
@cybersalt
Copy link

I have tested this item ✅ successfully on a80245d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

@HLeithner HLeithner changed the title [5.0] com_contact remove showon when useglobal is used in the field [5.1] com_contact remove showon when useglobal is used in the field Apr 24, 2024
Copy link
Contributor

@bembelimen bembelimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like Harald said, removing the option does not fix the issue: #42386 (comment)

@bembelimen
Copy link
Contributor

Back to pending


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 11, 2024
@bembelimen bembelimen added the RMDQ ReleaseManagerDecisionQueue label May 11, 2024
@drmenzelit
Copy link
Contributor Author

Like Harald said, removing the option does not fix the issue: #42386 (comment)

I was not able to find the code for that ... #42386 (comment)

@drmenzelit
Copy link
Contributor Author

This PR doesn't solve the underlying problem of showon fields. We need more coding effort for that.

@drmenzelit drmenzelit closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PR-5.1-dev RMDQ ReleaseManagerDecisionQueue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants