-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] com_contact remove showon when useglobal is used in the field #42386
Conversation
maybe it's better to fix the real issue if the issue is true for all global based showOns ? |
Yes ;-) useglobal inserts a new select option but without value ... do you know where that is created? |
I have tested this item ✅ successfully on 441e2f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386. |
I have tested this item ✅ successfully on 441e2f1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386. |
I have tested this item ✅ successfully on a80245d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like Harald said, removing the option does not fix the issue: #42386 (comment)
Back to pending This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42386. |
I was not able to find the code for that ... #42386 (comment) |
This PR doesn't solve the underlying problem of showon fields. We need more coding effort for that. |
Pull Request for Issue #42381 .
Summary of Changes
Removed the showon option in several fields
Testing Instructions
See issue #42381
Actual result BEFORE applying this Pull Request
Showon fields are not displayed in contact and menu item if the "parent" field has useglobal
Expected result AFTER applying this Pull Request
Showon fields are displayed
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed