Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] [com_scheduler] task execution history view #42530

Open
wants to merge 46 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Dec 16, 2023

Summary of Changes

Add task execution history view

Testing Instructions

apply pr
run the sql script 5.2.0-2023-12-16.sql

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

click on Execution History button

image

for the task execution history view

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels Dec 16, 2023
@alikon alikon added the Feature label Dec 17, 2023
@richard67
Copy link
Member

@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?

@alikon
Copy link
Contributor Author

alikon commented Dec 19, 2023

@alikon I see that the new table has different default values for some columns for MySQL and PostgreSQL. E.g. the "taskname" column has default value empty string for MySQL and no default value for PostgreSQL. That's just one example, there are more. Shouldn't the default values be consistent?

silly me, that i've mimed what was already done for the #__scheduler_tasks table

and yes must be consistent.....i'll do something

@Quy
Copy link
Contributor

Quy commented Mar 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 29, 2024
@alikon
Copy link
Contributor Author

alikon commented Apr 11, 2024

no interest

@alikon alikon closed this Apr 11, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 11, 2024
@dautrich
Copy link

What happened to this PR? Obviously, it's not included in 5.1.1. Will it be part of 5.2?

IMHO it would be a great tool to trace the executions of task plugins in case of any issues. At the moment I have such an issue with a task plugin.

@alikon alikon reopened this Jun 20, 2024
@Quy
Copy link
Contributor

Quy commented Jun 26, 2024

This should be rebased for 5.2

@rdeutz
Copy link
Contributor

rdeutz commented Jul 30, 2024

no interest

I like it, maybe was to late for 5.1, rebase to 5.2 would be good

@rdeutz rdeutz changed the base branch from 5.1-dev to 5.2-dev July 30, 2024 06:35
@rdeutz rdeutz changed the title [5.1][com_scheduler] task execution history view [5.2][com_scheduler] task execution history view Jul 30, 2024
@rdeutz rdeutz added RTC This Pull Request is Ready To Commit and removed PR-5.1-dev labels Jul 30, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 7, 2024
@bascherz
Copy link

I have tested this item 🔴 unsuccessfully on 585ebdd

Tested on a fresh installation of 5.2.0-beta1. Note that there was no execution history for any of the default tasks and I did not run SQL script 5.2.0-2023-12-16.sql (Testing Instructions need updating). Got the following error when I clicked the "Execution History" button for each of them. This should be preventable and should not require the table to exist.

An error has occurred.
500 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist 42S02, 1146, Table 'ua887228_scherzingertest.j52test_scheduler_logs' doesn't exist
Call Stack

Function Location

1 () JROOT/administrator/components/com_scheduler/src/View/Logs/HtmlView.php:97
2 Joomla\Component\Scheduler\Administrator\View\Logs\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
3 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_scheduler/src/Controller/DisplayController.php:59
4 Joomla\Component\Scheduler\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
5 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
6 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
7 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
8 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
9 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
10 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
11 require_once() JROOT/administrator/index.php:32

After executing the SQL script, which creates the missing table, the error was eliminated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42530.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:52
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2][com_scheduler] task execution history view [5.3] [com_scheduler] task execution history view Sep 2, 2024
@Hackwar Hackwar removed the PR-5.2-dev label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.