Fix phpdoc in FeatureEvent #42585
Closed
Fix phpdoc in FeatureEvent #42585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Denitz As far as I can see, the same issue already exists in the 4.,4-dev branch. So if we consider your fix to be a bug fix, it should be made for 4.4-dev and later will be merged up into 5.0-dev. And if we consider it a new feature (which would be not appropriate, I think) it would go into 5.1-dev. I've asked maintainers for their opinion and will let you know the result, but I think it would also be ok if you just rebase to or redo it for 4.4-dev. |
|
@richard67 Yes, you are right, 4.4-dev is the right place for this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Invalid phpdoc
Testing Instructions
Feature/unfeature article.
Actual result BEFORE applying this Pull Request
Invalid phpdoc
Expected result AFTER applying this Pull Request
Valid phpdoc
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed