Change type of field "value" in table `#_fields_values` from text to mediumtext #42605

sergeytolkachyov · 2024-01-04T09:22:19Z

Change type of field "value" in table #_fields_values from text to mediumtext for MySQL ONLY. PostgreSQL have only text field type with unlimited length. Pull Request for Issue #36065

… PR 42489 (#42550) * Better English (1) Co-authored-by: Brian Teeman <brian@teeman.net> * Better English (2) Co-authored-by: Brian Teeman <brian@teeman.net> * Remove br html element from language strings --------- Co-authored-by: Brian Teeman <brian@teeman.net>

…diumtext. Related to #36065

Fixes hardening measure introduced in #23716

* load lang * test-4-dupkey ---------

Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

backport [5] update from nightly to latest nightly build #41865

[5.0] Upmerge 2023-12-30

* Fix `function` parameter lost during redirect Currently if you are switching the menu filter in the menu item select modal, the function parameter will be lost on redirect. * Move function parameter to form url * Remove hidden input

…_SIZE rows" when checking for core updates (#42576) * Use concat of columns for getting core extensions * Fix PHPCS * Remove wrong quotes

* cast to int for pgsql * yet-another ---------

[5.0] Upmerge 2024-01-02

…diumtext for MySQL ONLY. PostgreSQL have only text field type with unlimited length. Related to #36065

sergeytolkachyov · 2024-01-04T09:23:57Z

Because J5.0.2 now is RC I moved it to 5.0.3.

sergeytolkachyov · 2024-01-04T09:28:56Z

@richard67 @HLeithner

richard67 · 2024-01-04T09:37:01Z

@sergeytolkachyov Meanwhile 5.0.x is in stable phase, so I think this PR here should be made for the 5.1-dev branch. Could you rebase your PR or redo it for 5.1-dev?

installation/sql/postgresql/supports.sql

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

sergeytolkachyov · 2024-01-04T09:42:39Z

@sergeytolkachyov Meanwhile 5.0.x is in stable phase, so I think this PR here should be made for the 5.1-dev branch. Could you rebase your PR or redo it for 5.1-dev?

Is this such a big change that it should only be in the minor version?

richard67 · 2024-01-04T09:46:03Z

Is this such a big change that it should only be in the minor version?

@sergeytolkachyov I will ask other maintainers or release managers for their opinion. Stay tuned.

HLeithner · 2024-01-04T09:46:26Z

@sergeytolkachyov Meanwhile 5.0.x is in stable phase, so I think this PR here should be made for the 5.1-dev branch. Could you rebase your PR or redo it for 5.1-dev?

Is this such a big change that it should only be in the minor version?

it's a feature and not a bugfix that's the reason why it should go into 5.1.

sergeytolkachyov · 2024-01-04T09:50:59Z

If you follow the semver, minor releases should include changes that do not lead to loss of backward compatibility and lead to the appearance of new functionality. While minor changes, bug fixes should be included in the patch version. As a result of applying the changes from this PR, nothing new will appear for either developers or users. The bug described in the issue will only be fixed.
Why is this a feature? Maybe for languages using the Latin alphabet, this is a feature - an increase in the amount of data for the field. But for languages where letters are stored in unicode, this is rather a bug fix, since it was impossible to store a large amount of data in the field values.

sergeytolkachyov · 2024-01-04T09:53:28Z

There is really no big difference when it will be enabled: in 5.0.3 or in 5.1. I just want to understand the logic.

HLeithner · 2024-01-04T09:56:11Z

everything which is not a bug is a feature, if you follow this you simple reduce the pain to upgrade. security stuff is another topic and a change like this doesn't need to hurry since you can fix it for your sites your self.

richard67 · 2024-01-04T10:05:28Z

administrator/components/com_admin/sql/updates/mysql/5.0.3-2024-01-04.sql

@@ -0,0 +1 @@
+ALTER TABLE `#__fields_values` MODIFY `value` MEDIUMTEXT;


Please rename the script from "5.0.3-2024-01-04.sql" to "5.1.0-2024-01-04.sql".

sergeytolkachyov · 2024-01-04T10:05:31Z

@sergeytolkachyov Meanwhile 5.0.x is in stable phase, so I think this PR here should be made for the 5.1-dev branch. Could you rebase your PR or redo it for 5.1-dev?

Is this such a big change that it should only be in the minor version?

it's a feature and not a bugfix that's the reason why it should go into 5.1.

It seems to have done a rebase...

richard67 · 2024-01-04T10:07:44Z

It seems to have done a rebase...

@sergeytolkachyov Yes. Now the PR shows more changes than only yours, and there are conflicts, but I think that should be solved with the next upmerge from 5.0-dev to 5.1-dev by the release managers and then updating your branch to the 5.1-dev.

In addition it needs to rename the update SQL script, see my review comment.

So maybe it's easier if you just close this PR and make a new one for the 5.1-dev branch.

sergeytolkachyov · 2024-01-04T10:37:34Z

So maybe it's easier if you just close this PR and make a new one for the 5.1-dev branch.

I made a #42606

richard67 · 2024-01-04T10:39:12Z

Thanks.

…diumtext for MySQL ONLY. PostgreSQL have only text field type with unlimited length. Pull Request for Issue #36065 and remake a PR #42605 for Joomla 5.1.0 (#42606)

RickR2H and others added 27 commits December 20, 2023 13:22

Fix link and button colors in header footer (#42504)

3aa5fa9

[4.x] add php 8.3 to tests (#42545)

d8648aa

Update the signature for #42545 (#42552)

6fc05f7

Change type of field "value" in table #_fields_values from text to me…

ba77187

…diumtext. Related to #36065

Fixes to form validation process (#42560)

58ccc93

Fixes hardening measure introduced in #23716

[4][com_actionlogs] missed load plugin languages (#42562)

3927cea

* load lang * test-4-dupkey ---------

Better message on package uninstallation (#42570)

e125943

Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

backport #41865 (#42088)

83f50fd

backport [5] update from nightly to latest nightly build #41865

[5] harmonize naming task types (#42574)

63b392a

[5.0] colour contrast in media manager file list [a11y] (#42544)

9248355

Merge remote-tracking branch 'Joomla/4.4-dev' into 5.0-dev

d76cf02

Merge pull request #42580 from bembelimen/5.0/upmerge-2023-12-30

af3ed9a

[5.0] Upmerge 2023-12-30

[5.0] Update phpseclib to 3.0.34 (#42469)

eaf830e

[4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN…

80751a6

…_SIZE rows" when checking for core updates (#42576) * Use concat of columns for getting core extensions * Fix PHPCS * Remove wrong quotes

Revert min version in drone (#42583)

2b1cc9a

Joomla! 5.0.2 Release Candidate 1

dfda820

Revert to dev

adbdb7f

[4][com_templates] cast to int for pgsql (#42569)

f97a4c5

* cast to int for pgsql * yet-another ---------

patch article tags (#42486)

56bf784

Merge remote-tracking branch 'Joomla/4.4-dev' into upmerges/2024-01-02

cfed3e1

Merge pull request #42591 from bembelimen/5.0/upmerge-2024-01-02

6be3854

[5.0] Upmerge 2024-01-02

Joomla 5.0.2 Release Candidate 2

2adbbbf

Reset to dev

94bf1eb

Merge branch 'joomla:5.0-dev' into 5.0-dev

0e7ba9b

Change type of field "value" in table #_fields_values from text to me…

d8d29a1

…diumtext for MySQL ONLY. PostgreSQL have only text field type with unlimited length. Related to #36065

joomla-cms-bot added the PR-5.0-dev label Jan 4, 2024

richard67 reviewed Jan 4, 2024

View reviewed changes

installation/sql/postgresql/supports.sql Outdated Show resolved Hide resolved

Update installation/sql/postgresql/supports.sql

c2d8503

Co-authored-by: Richard Fath <richard67@users.noreply.github.com>

sergeytolkachyov changed the base branch from 5.0-dev to 5.1-dev January 4, 2024 10:03

sergeytolkachyov requested review from laoneo, rdeutz, Hackwar and zero-24 as code owners January 4, 2024 10:03

richard67 reviewed Jan 4, 2024

View reviewed changes

sergeytolkachyov closed this Jan 4, 2024

joomla-cms-bot added Composer Dependency Changed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev Unit/System Tests labels Jan 4, 2024

sergeytolkachyov mentioned this pull request Jan 4, 2024

Change type of field "value" in table #_fields_values from text to mediumtext #42606

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change type of field "value" in table `#_fields_values` from text to mediumtext #42605

Change type of field "value" in table `#_fields_values` from text to mediumtext #42605

sergeytolkachyov commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

HLeithner commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024 •

edited

Loading

sergeytolkachyov commented Jan 4, 2024

HLeithner commented Jan 4, 2024

richard67 Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024 •

edited

Loading

richard67 commented Jan 4, 2024

		@@ -0,0 +1 @@
		ALTER TABLE `#__fields_values` MODIFY `value` MEDIUMTEXT;

Change type of field "value" in table #_fields_values from text to mediumtext #42605

Change type of field "value" in table #_fields_values from text to mediumtext #42605

Conversation

sergeytolkachyov commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

HLeithner commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024 • edited Loading

sergeytolkachyov commented Jan 4, 2024

HLeithner commented Jan 4, 2024

richard67 Jan 4, 2024

Choose a reason for hiding this comment

sergeytolkachyov commented Jan 4, 2024

richard67 commented Jan 4, 2024

sergeytolkachyov commented Jan 4, 2024 • edited Loading

richard67 commented Jan 4, 2024

Change type of field "value" in table `#_fields_values` from text to mediumtext #42605

Change type of field "value" in table `#_fields_values` from text to mediumtext #42605

sergeytolkachyov commented Jan 4, 2024 •

edited

Loading

sergeytolkachyov commented Jan 4, 2024 •

edited

Loading