Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Atom Feed: Prevent notice from empty description #42670

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 17, 2024

Pull Request for Issue #41824.

Summary of Changes

In PHP 8.2, the changed line creates a notice when calling a category blog view with ?format=feed&type=atom attached to the URL. This fixes that.

Testing Instructions

  1. Open a category blog page on a site on PHP 8.2 and attach ?format=feed&type=atom to the URL.
  2. Look at the output.

Actual result BEFORE applying this Pull Request

A notice is shown:
Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in /home/www/libraries/src/Document/Renderer/Feed/AtomRenderer.php on line 89

Expected result AFTER applying this Pull Request

The notice is not there.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@MacJoom MacJoom self-assigned this Jan 18, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Jan 18, 2024

I have tested this item ✅ successfully on 5c66558

On Jooma 4.4-dev PHP 8.2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

@MacJoom MacJoom removed their assignment Jan 18, 2024
@richard67 richard67 added PHP 8.x PHP 8.x deprecated issues bug labels Jan 18, 2024
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 5c66558


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

@richard67 richard67 added PBF Pizza, Bugs and Fun and removed bug labels Jan 18, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42670.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 18, 2024
@richard67 richard67 added bug and removed PBF Pizza, Bugs and Fun labels Jan 18, 2024
@laoneo laoneo merged commit deae2f0 into joomla:4.4-dev Jan 19, 2024
2 of 3 checks passed
@laoneo
Copy link
Member

laoneo commented Jan 19, 2024

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 19, 2024
@laoneo laoneo added this to the Joomla 4.4.3 milestone Jan 19, 2024
@Hackwar Hackwar deleted the 4.4-feed-atom branch January 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PHP 8.x PHP 8.x deprecated issues PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants