Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Finder: Fixing language of token #42693

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 22, 2024

Summary of Changes

While debugging another issue, I stumbled upon a problem where the language handed over for a token while indexing is being set to NULL. For this to happen, Finder needs to be set to search for phrases. In that case, the changed line applies the stemming code to each token, but since $lang is only a single entry array, that variable is only applied once for the array of tokens. The token array can have between 1 and 3 entries and thus the stemmer for $lang is only applied for the first token and not the rest of the array.

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@rdeutz rdeutz self-requested a review February 5, 2024 12:32
@Hackwar Hackwar added PBF Pizza, Bugs and Fun bug and removed PBF Pizza, Bugs and Fun labels Feb 20, 2024
@MacJoom MacJoom self-assigned this Feb 22, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.4 milestone Feb 22, 2024
@MacJoom MacJoom merged commit ce13d13 into joomla:4.4-dev Feb 22, 2024
3 checks passed
@Hackwar Hackwar deleted the 4.4-finder-token branch March 22, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants