Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Feed: Fixing link selection of AtomParser #42706

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 24, 2024

Pull Request for Issue #38631 .

Summary of Changes

The feed parser for Atom feeds is selecting the wrong link as described in the original issue.

Testing Instructions

Copied from the original issue:

  1. Create new Feed Display module
  2. Set Feed URL to a Blogger Atom Feed eg https://www.failureasaservice.com/feeds/posts/default

Actual result BEFORE applying this Pull Request

Link is created using the first entry <link rel="replies"> which is an XML feed and not useful for normal users who just want to jump over to your post on Blogger.com.

<link rel="replies" type="application/atom+xml" href="https://www.failureasaservice.com/feeds/921417709640098202/comments/default" title="Post Comments"/>
    <link rel="replies" type="text/html" href="https://www.failureasaservice.com/2020/10/amd-killed-arm-in-data-center.html#comment-form" title="0 Comments"/>
    <link rel="edit" type="application/atom+xml" href="https://www.blogger.com/feeds/3991757369876144735/posts/default/921417709640098202"/>
    <link rel="self" type="application/atom+xml" href="https://www.blogger.com/feeds/3991757369876144735/posts/default/921417709640098202"/>
    <link rel="alternate" type="text/html" href="https://www.failureasaservice.com/2020/10/amd-killed-arm-in-data-center.html" title="AMD Killed ARM in the Data Center"/>

Expected result AFTER applying this Pull Request

Links should use the <link rel="alternate"> entry creating a clickable jump back to the Blogger page.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@fgsw
Copy link

fgsw commented Jan 26, 2024

image

Without the pr a click on 'FaaS - Failure as a Service' and 'AMD Killed ARM in the Data Center' opens

image

PR applied only the first link opens the above window.

@Hackwar Hackwar added PBF Pizza, Bugs and Fun bug labels Feb 20, 2024
@tomsrocket
Copy link

I have tested this item ✅ successfully on 231e360

The links on the feed headlines go to the article html pages. that is good.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706.

@TLWebdesign
Copy link

TLWebdesign commented Feb 24, 2024

Hi @Hackwar i'm testing this PR but i don't see a change in the dom of the urls of the blog items in the feed. they all have rel="noopener" even after applying the patch. But i do notice a change in behaviour as that now it opens the actual article instead of the feed link when clicking on the items. Seems like a half successfull test no?

Scherm­afbeelding 2024-02-24 om 12 26 30

@Hackwar
Copy link
Member Author

Hackwar commented Feb 24, 2024

@TLWebdesign that is the expected behavior, so your test would be successfull.

@TLWebdesign
Copy link

I have tested this item ✅ successfully on 231e360

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706.

@richard67 richard67 removed PBF Pizza, Bugs and Fun bug PR-4.4-dev labels Feb 24, 2024
@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42706.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 24, 2024
@richard67 richard67 added PBF Pizza, Bugs and Fun bug PR-4.4-dev labels Feb 24, 2024
@MacJoom MacJoom self-assigned this Feb 26, 2024
@laoneo laoneo added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 4, 2024
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
@laoneo laoneo removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Mar 4, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.4 milestone Mar 4, 2024
@MacJoom MacJoom merged commit 0a912a8 into joomla:4.4-dev Mar 4, 2024
0 of 2 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Mar 4, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 4, 2024
@Hackwar Hackwar deleted the 4.4-feed-atomparser branch March 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug PBF Pizza, Bugs and Fun PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants