Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Smart Search: Don't search for alternative images #42725

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 29, 2024

Pull Request for Issue #42320.

Summary of Changes

When an articles intro image contains a blank space, our code to search for related files in the media folder strips the whole image from the output of the search results. This change prevents this. The images of a search result should be the exact images, not the potential compressed files or similar from the media folder.

Testing Instructions

  1. Add an image with a space in the filename in the /images folder
  2. Edit an article and set the intro image to that image. By saving, the index should be updated.
  3. Set the image to be displayed in the search results in the configuration of either the search menu item or in the smart search global configuration.
  4. Search for the article

Actual result BEFORE applying this Pull Request

The article is displayed without the image.

Expected result AFTER applying this Pull Request

The article is displayed WITH the image.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jan 30, 2024

I have tested this item ✅ successfully on 4127a34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

1 similar comment
@fgsw
Copy link

fgsw commented Jan 30, 2024

I have tested this item ✅ successfully on 4127a34


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

@alikon
Copy link
Contributor

alikon commented Jan 30, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42725.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 30, 2024
@MacJoom MacJoom added this to the Joomla 4.4.3 milestone Feb 5, 2024
@MacJoom MacJoom self-assigned this Feb 5, 2024
@MacJoom MacJoom merged commit 6253096 into joomla:4.4-dev Feb 5, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 5, 2024
@MacJoom
Copy link
Contributor

MacJoom commented Feb 5, 2024

Thank you!

@Hackwar Hackwar deleted the 4.4-finder-image branch March 22, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants