Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Update Installer.php #42732

Open
wants to merge 1 commit into
base: 4.4-dev
Choose a base branch
from

Conversation

stell
Copy link
Contributor

@stell stell commented Jan 30, 2024

If you have complex, database-heavy extensions that have been in existence for many years, it often happens that SQL errors occur in the installation routine during updates at long intervals for various reasons.
At present, only the error is displayed, but not in which update file it occurred. If there are 50 such files, the search for the error can be unnecessarily lengthy.

Summary of Changes

Updated one line to be able to name the responsible file.

Actual result BEFORE applying this Pull Request

Example:
Installer: :Install: Error SQL Duplicate column name 'uid'

Expected result AFTER applying this Pull Request

Example:
Installer: :Install: Error SQL Duplicate column name 'uid' (4.3.3.sql)

Add update file for better debugging
@ceford
Copy link
Contributor

ceford commented Feb 26, 2024

Could not see an easy way for me to live test this but I did check the code, applied the patch and installed an extension. Pass!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42732.

@ceford
Copy link
Contributor

ceford commented Feb 26, 2024

I have tested this item ✅ successfully on 3915cb1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42732.

@exlemor
Copy link

exlemor commented Apr 21, 2024

Hi @stell, I can't see/understand/figure out how to test this based on what you wrote (sorry), if you can provide a file or a specific way to test it, i'll gladly test it.

@HLeithner
Copy link
Member

It's a feature shouldn't be merged in to 4.4

@HLeithner HLeithner changed the title Update Installer.php [4.4] Update Installer.php Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants