-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Complete com_search deprecation #40727 #42891
Conversation
joomla#40727 deprecated various search methods in `libraries/src/Language/Language.php` This PR completes that PR by deprecating their use in the localise.php file
it's too late to deprecated anything in 4.4, that's only allowed in x.y.0 releases. In this case I would deprecate it with 5.1 and remove it with 7.0 |
I have tested this item ✅ successfully on 51255d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891. |
@brianteeman then we have to change these depreciations you are talking about to 7.0 as well. Better to follow our deprecation policy and postpone already added deprecations than vice versa. |
fine by me |
@brianteeman can you rebase this one to 5.1-dev, so we can merge it. |
I have tested this item ✅ successfully on f7ac86b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42891. |
@laoneo I did what you asked and rebased it. Any reason why it cant be merged now? |
This is up to @bembelimen or @LadySolveig as they are the RM. |
This is now also to late for 5.1, so it would have to go into 5.2-dev |
I am not remaking it. Someone else can fix your mistake. The pr was made and tested in good time. |
Thank you @brianteeman and for review @ceford and @laoneo |
thanks - appreciate it |
@hackware deprecated various search methods in
libraries/src/Language/Language.php
in #40727This PR completes that PR by deprecating their use in the localise.php file
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed