Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Fix SEF redirect while executing parseRule #42932

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Mar 1, 2024

Summary of Changes

SEF plugin should not do redirect while parsing the URL.
Original PR:

Testing Instructions

Please re-test linked PRs, they should still work as before.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Ping @Hackwar

Co-authored-by: Quy <quy@nomonkeybiz.com>
@bembelimen bembelimen self-assigned this Mar 1, 2024
Copy link
Member

@HLeithner HLeithner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we talked about a redirection queue somewhere?

plugins/system/sef/src/Extension/Sef.php Outdated Show resolved Hide resolved
plugins/system/sef/src/Extension/Sef.php Outdated Show resolved Hide resolved
@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on 35f024e

I've tested the changes, works as described!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42932.

Co-authored-by: Harald Leithner <leithner@itronic.at>
@Fedik
Copy link
Member Author

Fedik commented Mar 3, 2024

Didn't we talked about a redirection queue somewhere?

Do not remember anything about it

@bembelimen bembelimen merged commit 32d4bf1 into joomla:5.1-dev Mar 4, 2024
0 of 2 checks passed
@bembelimen
Copy link
Contributor

Thx

@bembelimen bembelimen added this to the Joomla! 5.1.0 milestone Mar 4, 2024
@Fedik Fedik deleted the sef-fix-redir branch March 4, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants