Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] SEF: Enable new SEF options for new installations #43024

Merged
merged 11 commits into from
Aug 15, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Mar 14, 2024

Summary of Changes

This PR enables the new SEF features for new installations by default. It also changes the value of the trailingslash option. In Joomla 6.0 we want to remove the "Do nothing" option again and it would be stupid to then have to switch between the values 1 and 2 instead of 0 and 1.

Testing Instructions

Codereview?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

shouldnt the default value in the xml match the value being set in the install sql?

@Hackwar
Copy link
Member Author

Hackwar commented Mar 14, 2024

No, because the default for existing installations should be the current behavior, not the new behavior. If I set the default to the value in the installation SQL, then a user editing the SEF plugin, not changing anything and then saving would have the new behavior.

@Hackwar Hackwar changed the title [5.1] Enable new SEF options for new installations [5.1] SEF: Enable new SEF options for new installations Apr 9, 2024
@Hackwar Hackwar changed the title [5.1] SEF: Enable new SEF options for new installations [5.2] SEF: Enable new SEF options for new installations Apr 9, 2024
@Hackwar Hackwar changed the base branch from 5.1-dev to 5.2-dev April 9, 2024 09:16
@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on d03b7bb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

@Quy
Copy link
Contributor

Quy commented Aug 15, 2024

I have tested this item ✅ successfully on f64664b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

@Quy
Copy link
Contributor

Quy commented Aug 15, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43024.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 15, 2024
@pe7er pe7er self-assigned this Aug 15, 2024
@pe7er pe7er enabled auto-merge (squash) August 15, 2024 14:38
@pe7er pe7er merged commit fac99cb into joomla:5.2-dev Aug 15, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2024
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Aug 15, 2024
@Hackwar Hackwar deleted the 5.1-router-enable branch August 15, 2024 19:53
@pe7er
Copy link
Contributor

pe7er commented Aug 15, 2024

Thanks @Hackwar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants