[4.4] Prevent step target to be recorded with empty spaces and prevent tour run fails #43039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trim the target to avoid javascript errors preventing a tour to start
Quy
reviewed
Mar 15, 2024
administrator/components/com_guidedtours/src/Table/StepTable.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Quy <quy@nomonkeybiz.com>
|
Tested this under Joomla 4.4.4 and under Safari v17.4.1 (19618.1.15.11.14) on Mac OS Sonoma 14.4.1 and I could not have it fail. [I have checked that there is a space before and after the field]. Sorry. |
HLeithner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The step target is trimmed to avoid javascript errors and preventing a tour to start (with an error message that does not really explain what was wrong)
Testing Instructions
Edit a tour step and edit the target, adding spaces before and after the content of the field.
Run the tour you have edited the step from.
The tour MAY fail (depending on the browser/system used). It failed on Safari.
Apply the patch.
Edit the target field for the step (so it can be saved). Once saved, the step target field should not contain any space.
Actual result BEFORE applying this Pull Request
The tour may not start (an error message is shown when you start the tour).
Expected result AFTER applying this Pull Request
The tour runs.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed