Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Backendmenu: Fixing export of additionla features for menu items #43188

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Apr 1, 2024

Partial Pull Request for Issue #41268 .

Summary of Changes

While looking at #41268 I noticed that the export of backend menus currently is not properly exporting the attributes for the quicktask, dashboard and ajax-badge feature. This PR fixes that.

Please note that the export also currently does not properly export the tree structure of the menu. This is fixed in #43178.

Please also note, that the backend menu items don't properly support the quicktask, dashboard and ajax badge features in the menu item configuration yet. This is something that needs to be fixed in another PR.

Testing Instructions

  1. Go to menu manager, filter by admin and create a new menu for the administrator. Make sure to select a preset to pre-populate the menu.
  2. In the menu manager, select the menu and click "Download as Preset"
  3. Compare the preset with your download

Actual result BEFORE applying this Pull Request

There is no dashboard="", quicktask="", "ajax-badge="" or icon, title and permission attribute for the quicktask in the XML. The preset and the export differ wildly.

Expected result AFTER applying this Pull Request

There are attributes for the above mentioned features and the preset and export are a lot more similar.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@chmst
Copy link
Contributor

chmst commented Jul 23, 2024

I have tested this item ✅ successfully on ee585f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43188.

@webnet-assmann
Copy link

I have tested this item ✅ successfully on ee585f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43188.

@Hackwar Hackwar added the RTC This Pull Request is Ready To Commit label Jul 23, 2024
@MacJoom MacJoom self-assigned this Jul 24, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.7 milestone Jul 24, 2024
@MacJoom MacJoom merged commit 1b5560a into joomla:4.4-dev Jul 24, 2024
4 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Jul 24, 2024

Thank you!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants