[5.2] remove margin-bottom on .btn styling to prevent nasty offset

[hans2103]

Pull Request for Issue # .

Summary of Changes

This PR will remove the following piece of SCSS and uses proper Bootstrap classNames to achieve the same goal.

joomla-cms/build/media_source/templates/site/cassiopeia/scss/vendor/bootstrap/_buttons.scss

Lines 50 to 57 in 45adb61

	@include media-breakpoint-down(lg) {
	.btn {
	margin-bottom: .25rem;
	}
	.input-group .btn {
	margin-bottom: 0;
	}
	}

PR #32697 introduced a margin-bottom of .25em on all buttons.
A fix made by @brianteeman prevented this to happen on buttons in an input-group.
Both are not needed when using proper Bootstrap classNames on the wrapping element.

Testing Instructions

• Joomla 5.1 with sample data installed.
• Compile SCSS
• Head over to page Typography and reduce the viewport. On mobile the elements with className .btn are stacked with a proper gap between.
• Login on frontend and click an item to edit. On mobile the elements with className .btn are stacked with a proper gap between.
• Go to a random page to invoke a 404. Inspect the button with home icon and text "Home page". On mobile this button has no obsolete margin-bottom anymore. And all elements with className .btn don't have a obsolete margin-bottom anymore.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Comment

Even Bootstrap core has no margins around buttons. See screenshot below where I have disabled the DOCS styling.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Which was the PR I made a partial fix in? Would like to check exactly what the issue it was fixing is still fixed. Thanks

[hans2103]

Which was the PR I made a partial fix in? Would like to check exactly what the issue it was fixing is still fixed. Thanks

#33928

Long live git blame for this.

[brianteeman]

Thanks

[HLeithner]

This pull request has been automatically rebased to 5.2-dev.

[JeroenMoolenschot]

I have tested this item ✅ successfully on bbc2940

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43247.}