-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.1] Proper support for avif/webp images #43295
Conversation
Co-authored-by: Quy <quy@nomonkeybiz.com>
I have tested this item ✅ successfully on 6f7b7cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
1 similar comment
I have tested this item ✅ successfully on 6f7b7cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
Can we remove the RTC. Turns out that PHP docs were wrong php/php-src#14010 Please test again with:
|
I have tested this item ✅ successfully on 84874f6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
Back to pending. @Quy Could you test again? Thanks in advance. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
It was commented elsewhere that this PR would also resolve an issue with files named JPG as opposed to jpg. Sorry to say this pr makes no difference |
I have tested this item ✅ successfully on 84874f6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43295. |
This pull request has been automatically rebased to 5.2-dev. |
@HLeithner why did you moved this one to 5.2? This is a bug fix nothing new here... |
I only had quick look and just classified it as feature since nobody else looked at it and added a label. If I'm wrong no problem can be changed back as long as nobody update the branch. |
AVIF support was added with #41381 but George missed some parts. This PR just adds them, it doesn't have to wait for 6 months Edit: actually it fixes the issue reported in the introductory PR: #41381 (comment) where you also responded: #41381 (comment) |
switched back to 5.1 thanks |
Thx |
Pull Request for Issue # .
Summary of Changes
Image
classcanvas.toDataURL()
spec: toDataURL
Testing Instructions
Either run
npm I
or use the package from the PRextract and upload the files Archive.zip
Delete/rename the files
Delete the files. Edit the Media Action plugin resize with some values (ie 800 and 500) and check that the images on upload are getting resized.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed