Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Refactor all instances of File to use framework #43362

Merged
merged 17 commits into from
Aug 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix error handling
  • Loading branch information
Hackwar committed May 30, 2024
commit 148c7c20de0768129334535df76d503d6117d08c
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,9 @@ protected function _getPackageFromUpload()
try {
File::upload($tmp_src, $tmp_dest, false, true);
} catch (FilesystemException $exception) {
Hackwar marked this conversation as resolved.
Show resolved Hide resolved
Factory::getApplication()->enqueueMessage(Text::_('COM_INSTALLER_MSG_INSTALL_WARNINSTALLUPLOADERROR'), 'error');

return false;
}

// Unpack the downloaded package file.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ protected function downloadPackage($url, $target)
try {
File::delete($target);
} catch (FilesystemException $exception) {

return false;
}
}

Expand Down Expand Up @@ -618,7 +618,7 @@ public function createUpdateFile($basename = null): bool
try {
File::delete($configpath);
} catch (FilesystemException $exception) {

return false;
}
}

Expand Down